Skip to content

Commit 265165b

Browse files
Adding changes based on review comments
1 parent 1cbb09b commit 265165b

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

mmv1/products/chronicle/ReferenceList.yaml

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2024 Google Inc.
1+
# Copyright 2025 Google Inc.
22
# Licensed under the Apache License, Version 2.0 (the "License");
33
# you may not use this file except in compliance with the License.
44
# You may obtain a copy of the License at
@@ -35,8 +35,6 @@ examples:
3535
min_version: 'beta'
3636
vars:
3737
reference_list_id: reference_list_id
38-
description: referencelist-description
39-
reference_list_entry_value: "referencelist-entry-value"
4038
test_env_vars:
4139
chronicle_id: 'CHRONICLE_ID'
4240

@@ -133,7 +131,6 @@ properties:
133131
description: |2-
134132
135133
Possible values:
136-
REFERENCE_LIST_SYNTAX_TYPE_UNSPECIFIED
137134
REFERENCE_LIST_SYNTAX_TYPE_PLAIN_TEXT_STRING
138135
REFERENCE_LIST_SYNTAX_TYPE_REGEX
139136
REFERENCE_LIST_SYNTAX_TYPE_CIDR

mmv1/templates/terraform/examples/chronicle_referencelist_basic.tf.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ resource "google_chronicle_reference_list" "{{$.PrimaryResourceId}}" {
33
location = "us"
44
instance = "{{index $.TestEnvVars "chronicle_id"}}"
55
reference_list_id = "{{index $.Vars "reference_list_id"}}"
6-
description = "{{index $.Vars "description"}}"
6+
description = "referencelist-description"
77
entries {
8-
value = "{{index $.Vars "reference_list_entry_value"}}"
8+
value = "referencelist-entry-value"
99
}
1010
syntax_type = "REFERENCE_LIST_SYNTAX_TYPE_PLAIN_TEXT_STRING"
1111
}

mmv1/third_party/terraform/services/chronicle/resource_chronicle_reference_list_test.go.tmpl

+4-4
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ resource "google_chronicle_reference_list" "example" {
5252
location = "us"
5353
instance = "%{chronicle_id}"
5454
reference_list_id = "tf_test_reference_list_id%{random_suffix}"
55-
description = "tf-test-referencelist-description%{random_suffix}"
55+
description = "referencelist-description"
5656
entries {
57-
value = "tf-test-referencelist-entry-value%{random_suffix}"
57+
value = "referencelist-entry-value"
5858
}
5959
syntax_type = "REFERENCE_LIST_SYNTAX_TYPE_PLAIN_TEXT_STRING"
6060
}
@@ -68,9 +68,9 @@ resource "google_chronicle_reference_list" "example" {
6868
location = "us"
6969
instance = "%{chronicle_id}"
7070
reference_list_id = "tf_test_reference_list_id%{random_suffix}"
71-
description = "tf-test-referencelist-description-updated%{random_suffix}"
71+
description = "referencelist-description-updated"
7272
entries {
73-
value = "tf-test-referencelist-entry-value-updated%{random_suffix}"
73+
value = "referencelist-entry-value-updated"
7474
}
7575
syntax_type = "REFERENCE_LIST_SYNTAX_TYPE_REGEX"
7676
}

0 commit comments

Comments
 (0)