Skip to content

Commit 37a5428

Browse files
committed
Tests passing locally
1 parent e2f495d commit 37a5428

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

mmv1/products/memorystore/Instance.yaml

+4-2
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ properties:
178178
- name: 'fixedFrequencySchedule'
179179
type: NestedObject
180180
description: "Optional. Trigger automated backups at a fixed frequency."
181+
required: true
181182
properties:
182183
- name: 'startTime'
183184
type: NestedObject
@@ -191,13 +192,14 @@ properties:
191192
description: |
192193
Hours of a day in 24 hour format. Must be greater than or equal to 0 and typically must be less than or equal to 23.
193194
An API may choose to allow the value "24:00:00" for scenarios like business closing time.
195+
required: true
194196
- name: 'retention'
195197
type: String
196198
description: |
197199
Optional. How long to keep automated backups before the backups are deleted.
198200
The value should be between 1 day and 365 days. If not specified, the default value is 35 days.
199-
A duration in seconds with up to nine fractional digits, ending with 's'. Example: "3.5s".
200-
default_value: "3024000s"
201+
A duration in seconds with up to nine fractional digits, ending with 's'. Example: "3.5s". The default_value is "3024000s"
202+
required: true
201203
- name: 'uid'
202204
type: String
203205
description: "Output only. System assigned, unique identifier for the instance. "

mmv1/third_party/terraform/services/memorystore/resource_memorystore_instance_test.go

+4-5
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,15 @@ func TestAccMemorystoreInstance_automatedBackupConfig(t *testing.T) {
6565
ResourceName: "google_memorystore_instance.test_abc",
6666
ImportState: true,
6767
ImportStateVerify: true,
68-
ImportStateVerifyIgnore: []string{"automated_backup_config.0.fixed_frequency_schedule", "automated_backup_config.0.fixed_frequency_schedule.0.start_time", "utomated_backup_config.0.fixed_frequency_schedule.0.start_time.0.hours", "automated_backup_config.0.retention"},
68+
ImportStateVerifyIgnore: []string{"automated_backup_config", "automated_backup_config.0", "automated_backup_config.0.fixed_frequency_schedule", "automated_backup_config.0.fixed_frequency_schedule.0.start_time", "utomated_backup_config.0.fixed_frequency_schedule.0.start_time.0.hours", "automated_backup_config.0.retention"},
6969
},
7070
{
7171
Config: testAccMemorystoreInstance_automatedBackupConfigWithout(context),
7272
},
7373
{
74-
ResourceName: "google_memorystore_instance.test_abc",
75-
ImportState: true,
76-
ImportStateVerify: true,
77-
ImportStateVerifyIgnore: []string{"automated_backup_config.0.fixed_frequency_schedule", "automated_backup_config.0.fixed_frequency_schedule.0.start_time", "utomated_backup_config.0.fixed_frequency_schedule.0.start_time.0.hours", "automated_backup_config.0.retention"},
74+
ResourceName: "google_memorystore_instance.test_abc",
75+
ImportState: true,
76+
ImportStateVerify: true,
7877
},
7978
},
8079
})

0 commit comments

Comments
 (0)