Promote google_chronicle_rule_deployment resource of chronicle to GA (#13481)

Author: ankitgoyal0301

mmv1/products/chronicle/RuleDeployment.yaml

@@ -14,11 +14,10 @@
 ---
 name: RuleDeployment
 description: The RuleDeployment resource represents the deployment state of a Rule.
-min_version: 'beta'
 references:
   guides:
     'Google SecOps Guides': 'https://cloud.google.com/chronicle/docs/secops/secops-overview'
-  api: 'https://cloud.google.com/chronicle/docs/reference/rest/v1alpha/RuleDeployment'
+  api: 'https://cloud.google.com/chronicle/docs/reference/rest/v1/RuleDeployment'
 base_url: projects/{{project}}/locations/{{location}}/instances/{{instance}}/rules/{{rules}}/deployments
 self_link: projects/{{project}}/locations/{{location}}/instances/{{instance}}/rules/{{rule}}/deployment
 create_url: projects/{{project}}/locations/{{location}}/instances/{{instance}}/rules/{{rule}}/deployment
@@ -39,17 +38,14 @@ custom_code:
 examples:
   - name: 'chronicle_ruledeployment_basic'
     primary_resource_id: 'example'
-    min_version: 'beta'
     test_env_vars:
       chronicle_id: 'CHRONICLE_ID'
   - name: 'chronicle_ruledeployment_disabled'
     primary_resource_id: 'example'
-    min_version: 'beta'
     test_env_vars:
       chronicle_id: 'CHRONICLE_ID'
   - name: 'chronicle_ruledeployment_run_frequency_missing'
     primary_resource_id: 'example'
-    min_version: 'beta'
     test_env_vars:
       chronicle_id: 'CHRONICLE_ID'
 

mmv1/templates/terraform/examples/chronicle_ruledeployment_basic.tf.tmpl

@@ -1,5 +1,4 @@
 resource "google_chronicle_rule" "my-rule" {
- provider = "google-beta"
  location = "us"
  instance = "{{index $.TestEnvVars "chronicle_id"}}"
  text = <<-EOT
@@ -8,7 +7,6 @@ resource "google_chronicle_rule" "my-rule" {
 }
 
 resource "google_chronicle_rule_deployment" "{{$.PrimaryResourceId}}" {
- provider = "google-beta"
  location = "us"
  instance = "{{index $.TestEnvVars "chronicle_id"}}"
  rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)

mmv1/templates/terraform/examples/chronicle_ruledeployment_disabled.tf.tmpl

@@ -1,5 +1,4 @@
 resource "google_chronicle_rule" "my-rule" {
- provider = "google-beta"
  location = "us"
  instance = "{{index $.TestEnvVars "chronicle_id"}}"
  text = <<-EOT
@@ -8,7 +7,6 @@ resource "google_chronicle_rule" "my-rule" {
 }
 
 resource "google_chronicle_rule_deployment" "{{$.PrimaryResourceId}}" {
- provider = "google-beta"
  location = "us"
  instance = "{{index $.TestEnvVars "chronicle_id"}}"
  rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)

mmv1/templates/terraform/examples/chronicle_ruledeployment_run_frequency_missing.tf.tmpl

@@ -1,5 +1,4 @@
 resource "google_chronicle_rule" "my-rule" {
- provider = "google-beta"
  location = "us"
  instance = "{{index $.TestEnvVars "chronicle_id"}}"
  text = <<-EOT
@@ -8,7 +7,6 @@ resource "google_chronicle_rule" "my-rule" {
 }
 
 resource "google_chronicle_rule_deployment" "{{$.PrimaryResourceId}}" {
- provider = "google-beta"
  location = "us"
  instance = "{{index $.TestEnvVars "chronicle_id"}}"
  rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)

mmv1/third_party/terraform/services/chronicle/resource_chronicle_rule_deployment_test.go.tmpl

@@ -1,7 +1,5 @@
 package chronicle_test
 
-{{- if ne $.TargetVersionName "ga" }}
-
 import (
 	"testing"
 
@@ -21,7 +19,7 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update(t
 
 	acctest.VcrTest(t, resource.TestCase{
 		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
-		ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
 		Steps: []resource.TestStep{
 			{
 				Config: testAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_basic(context),
@@ -48,7 +46,6 @@ func TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update(t
 func testAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_basic(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 resource "google_chronicle_rule" "my-rule" {
- provider = "google-beta"
  location = "us"
  instance = "%{chronicle_id}"
  text = <<-EOT
@@ -57,7 +54,6 @@ resource "google_chronicle_rule" "my-rule" {
 }
 
 resource "google_chronicle_rule_deployment" "example" {
- provider = "google-beta"
  location = "us"
  instance = "%{chronicle_id}"
  rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)
@@ -72,7 +68,6 @@ resource "google_chronicle_rule_deployment" "example" {
 func testAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 resource "google_chronicle_rule" "my-rule" {
- provider = "google-beta"
  location = "us"
  instance = "%{chronicle_id}"
  text = <<-EOT
@@ -81,7 +76,6 @@ resource "google_chronicle_rule" "my-rule" {
 }
 
 resource "google_chronicle_rule_deployment" "example" {
- provider = "google-beta"
  location = "us"
  instance = "%{chronicle_id}"
  rule = element(split("/", resource.google_chronicle_rule.my-rule.name), length(split("/", resource.google_chronicle_rule.my-rule.name)) - 1)
@@ -92,4 +86,3 @@ resource "google_chronicle_rule_deployment" "example" {
 }
 `, context)
 }
-{{- end }}