Supporting gke hub feature data source to know if the feature is enabled or not

Author: YpNo

mmv1/third_party/terraform/provider/provider_mmv1_resources.go.tmpl

@@ -130,6 +130,7 @@ var handwrittenDatasources = map[string]*schema.Resource{
 	"google_dns_managed_zones":                         dns.DataSourceDnsManagedZones(),
 	"google_dns_record_set":                            dns.DataSourceDnsRecordSet(),
 	"google_gke_hub_membership_binding":                gkehub2.DataSourceGoogleGkeHubMembershipBinding(),
+	"google_gke_hub_feature":                           gkehub2.DataSourceGoogleGkeHubFeature(),
 	"google_filestore_instance":                        filestore.DataSourceGoogleFilestoreInstance(),
 	"google_iam_policy":                                resourcemanager.DataSourceGoogleIamPolicy(),
 	"google_iam_role":                                  resourcemanager.DataSourceGoogleIamRole(),

mmv1/third_party/terraform/services/gkehub2/data_source_google_gke_hub_feature.go

@@ -0,0 +1,50 @@
+package gkehub2
+
+import (
+	"fmt"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
+	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
+)
+
+func DataSourceGoogleGkeHubFeature() *schema.Resource {
+	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(ResourceGKEHub2Feature().Schema)
+	tpgresource.AddRequiredFieldsToSchema(dsSchema, "location")
+	tpgresource.AddRequiredFieldsToSchema(dsSchema, "project")
+	tpgresource.AddRequiredFieldsToSchema(dsSchema, "feature")
+
+	return &schema.Resource{
+		Read:   dataSourceGoogleGkeHubFeatureRead,
+		Schema: dsSchema,
+	}
+}
+
+func dataSourceGoogleGkeHubFeatureRead(d *schema.ResourceData, meta interface{}) error {
+	config := meta.(*transport_tpg.Config)
+
+	id, err := tpgresource.ReplaceVars(d, config, "projects/{{project}}/locations/{{location}}/features/{{feature}}")
+	if err != nil {
+		return fmt.Errorf("Error constructing id: %s", err)
+	}
+
+	d.SetId(id)
+
+	err = resourceGKEHub2FeatureRead(d, meta)
+	if err != nil {
+		return err
+	}
+
+	if err := tpgresource.SetDataSourceLabels(d); err != nil {
+		return err
+	}
+
+	if err := tpgresource.SetDataSourceAnnotations(d); err != nil {
+		return err
+	}
+
+	if d.Id() == "" {
+		return fmt.Errorf("%s not found", id)
+	}
+	return nil
+}

mmv1/third_party/terraform/services/gkehub2/data_source_google_gke_hub_feature_test.go

@@ -0,0 +1,56 @@
+package gkehub2_test
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-provider-google/google/acctest"
+	"github.com/hashicorp/terraform-provider-google/google/envvar"
+)
+
+func TestAccDataSourceGoogleGKEHub2Feature_basic(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"org_id":          envvar.GetTestOrgFromEnv(t),
+		"billing_account": envvar.GetTestBillingAccountFromEnv(t),
+		"random_suffix":   acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckGKEHub2FeatureDestroyProducer(t),
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"time": {},
+		},
+		Steps: []resource.TestStep{
+			{
+				Config: testAccDataSourceGoogleGKEHub2Feature_basic(context),
+				Check: resource.ComposeTestCheckFunc(
+					acctest.CheckDataSourceStateMatchesResourceState("data.google_gke_hub_feature.feature", "google_gke_hub_feature.feature"),
+				),
+			},
+		},
+	})
+}
+
+func testAccDataSourceGoogleGKEHub2Feature_basic(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+data "google_project" "project" {}
+
+resource "google_gke_hub_feature" "feature" {
+  name = "servicemesh"
+  location = "global"
+  project = data.google_project.project.project_id
+
+  depends_on = [time_sleep.wait_for_gkehub_enablement]
+}
+
+data "google_gke_hub_feature" "feature" {
+  location = google_gke_hub_feature.feature.location
+  project = data.google_project.project.project_id
+  feature = google_gke_hub_feature.feature.name
+}
+`, context)
+}