Skip to content

Commit b1a07f0

Browse files
authored
Revert "Parallelstore: adding deployment type to beta provider and making network field required. " (#12559)
1 parent 4840e02 commit b1a07f0

File tree

3 files changed

+3
-71
lines changed

3 files changed

+3
-71
lines changed

mmv1/products/parallelstore/Instance.yaml

+1-18
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,6 @@ async:
3737
resource_inside_response: true
3838
custom_code:
3939
examples:
40-
- name: 'parallelstore_instance_basic_beta'
41-
primary_resource_id: 'instance'
42-
min_version: 'beta'
43-
vars:
44-
name: 'instance'
45-
network_name: 'network'
46-
address_name: 'address'
4740
- name: 'parallelstore_instance_basic'
4841
primary_resource_id: 'instance'
4942
vars:
@@ -148,9 +141,8 @@ properties:
148141
type: String
149142
- name: 'network'
150143
type: String
151-
required: true
152144
description: |
153-
Required. Immutable. The name of the Google Compute Engine [VPC network](https://cloud.google.com/vpc/docs/vpc)
145+
Immutable. The name of the Google Compute Engine [VPC network](https://cloud.google.com/vpc/docs/vpc)
154146
to which the instance is connected.
155147
immutable: true
156148
- name: 'reservedIpRange'
@@ -192,12 +184,3 @@ properties:
192184
DIRECTORY_STRIPE_LEVEL_MIN
193185
DIRECTORY_STRIPE_LEVEL_BALANCED
194186
DIRECTORY_STRIPE_LEVEL_MAX
195-
- name: deploymentType
196-
type: String
197-
min_version: 'beta'
198-
description: |
199-
Parallelstore Instance deployment type.
200-
Possible values:
201-
DEPLOYMENT_TYPE_UNSPECIFIED
202-
SCRATCH
203-
PERSISTENT

mmv1/templates/terraform/examples/parallelstore_instance_baic_beta.tmpl

-40
This file was deleted.

mmv1/third_party/terraform/services/parallelstore/resource_parallelstore_instance_test.go.tmpl

+2-13
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
package parallelstore_test
2020

21-
{{ if ne $.TargetVersionName `ga` -}}
2221
import (
2322
"testing"
2423

@@ -35,7 +34,7 @@ func TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update(t *te
3534

3635
acctest.VcrTest(t, resource.TestCase{
3736
PreCheck: func() { acctest.AccTestPreCheck(t) },
38-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
37+
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
3938
CheckDestroy: testAccCheckParallelstoreInstanceDestroyProducer(t),
4039
Steps: []resource.TestStep{
4140
{
@@ -71,7 +70,6 @@ resource "google_parallelstore_instance" "instance" {
7170
network = google_compute_network.network.name
7271
reserved_ip_range = google_compute_global_address.private_ip_alloc.name
7372
file_stripe_level = "FILE_STRIPE_LEVEL_MIN"
74-
provider = google-beta
7573
directory_stripe_level = "DIRECTORY_STRIPE_LEVEL_MIN"
7674
labels = {
7775
test = "value"
@@ -82,7 +80,6 @@ resource "google_parallelstore_instance" "instance" {
8280
resource "google_compute_network" "network" {
8381
name = "network%{random_suffix}"
8482
auto_create_subnetworks = true
85-
provider = google-beta
8683
mtu = 8896
8784
}
8885

@@ -93,7 +90,6 @@ resource "google_compute_global_address" "private_ip_alloc" {
9390
name = "address%{random_suffix}"
9491
purpose = "VPC_PEERING"
9592
address_type = "INTERNAL"
96-
provider = google-beta
9793
prefix_length = 24
9894
network = google_compute_network.network.id
9995
}
@@ -102,7 +98,6 @@ resource "google_compute_global_address" "private_ip_alloc" {
10298
resource "google_service_networking_connection" "default" {
10399
network = google_compute_network.network.id
104100
service = "servicenetworking.googleapis.com"
105-
provider = google-beta
106101
reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
107102
}
108103
`, context)
@@ -116,7 +111,7 @@ resource "google_parallelstore_instance" "instance" {
116111
description = "test instance updated"
117112
capacity_gib = 12000
118113
network = google_compute_network.network.name
119-
provider = google-beta
114+
120115
labels = {
121116
test = "value23"
122117
}
@@ -127,7 +122,6 @@ resource "google_compute_network" "network" {
127122
name = "network%{random_suffix}"
128123
auto_create_subnetworks = true
129124
mtu = 8896
130-
provider = google-beta
131125
}
132126

133127

@@ -138,19 +132,14 @@ resource "google_compute_global_address" "private_ip_alloc" {
138132
purpose = "VPC_PEERING"
139133
address_type = "INTERNAL"
140134
prefix_length = 24
141-
provider = google-beta
142135
network = google_compute_network.network.id
143136
}
144137

145138
# Create a private connection
146139
resource "google_service_networking_connection" "default" {
147140
network = google_compute_network.network.id
148-
provider = google-beta
149141
service = "servicenetworking.googleapis.com"
150142
reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
151143
}
152144
`, context)
153-
}
154-
155-
{{ end }}
156145
}

0 commit comments

Comments
 (0)