Skip to content

Commit bef372a

Browse files
author
Aleksandra Jarmolińska
committed
Fixes to how the kms key is passed
1 parent e6f6357 commit bef372a

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

mmv1/third_party/terraform/tests/resource_composer_environment_test.go.erb

+9-9
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,8 @@ func TestAccComposerEnvironment_withWebServerConfig(t *testing.T) {
298298
func TestAccComposerEnvironment_withEncryptionConfig(t *testing.T) {
299299
t.Parallel()
300300

301-
kms := BootstrapKMSKey(t)
302-
pid := getTestProjectFromEnv()
301+
kms := BootstrapKMSKey(t)
302+
pid := getTestProjectFromEnv()
303303
envName := fmt.Sprintf("%s-%d", testComposerEnvironmentPrefix, randInt(t))
304304
network := fmt.Sprintf("%s-%d", testComposerNetworkPrefix, randInt(t))
305305
subnetwork := network + "-1"
@@ -310,7 +310,7 @@ func TestAccComposerEnvironment_withEncryptionConfig(t *testing.T) {
310310
CheckDestroy: testAccComposerEnvironmentDestroyProducer(t),
311311
Steps: []resource.TestStep{
312312
{
313-
Config: testAccComposerEnvironment_encryptionCfg(envName, network, subnetwork),
313+
Config: testAccComposerEnvironment_encryptionCfg(pid, envName, kms.CryptoKey.Name, network, subnetwork),
314314
},
315315
{
316316
ResourceName: "google_composer_environment.test",
@@ -320,12 +320,12 @@ func TestAccComposerEnvironment_withEncryptionConfig(t *testing.T) {
320320
// This is a terrible clean-up step in order to get destroy to succeed,
321321
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
322322
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
323-
{
324-
PlanOnly: true,
325-
ExpectNonEmptyPlan: false,
326-
Config: testAccComposerEnvironment_encryptionCfgUpdated(envName, network, subnetwork),
327-
Check: testAccCheckClearComposerEnvironmentFirewalls(t, network),
328-
},
323+
// {
324+
// PlanOnly: true,
325+
// ExpectNonEmptyPlan: false,
326+
// Config: testAccComposerEnvironment_encryptionCfgUpdated(envName, network, subnetwork),
327+
// Check: testAccCheckClearComposerEnvironmentFirewalls(t, network),
328+
// },
329329
},
330330
})
331331
}

0 commit comments

Comments
 (0)