Skip to content

Commit cdc782c

Browse files
committed
Fixed PR based on comments
1 parent 5654211 commit cdc782c

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

mmv1/third_party/terraform/provider/provider_mmv1_resources.go.tmpl

+5-3
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ var handwrittenDatasources = map[string]*schema.Resource{
2222
"google_access_approval_project_service_account": accessapproval.DataSourceAccessApprovalProjectServiceAccount(),
2323
"google_access_context_manager_access_policy": accesscontextmanager.DataSourceAccessContextManagerAccessPolicy(),
2424
"google_active_folder": resourcemanager.DataSourceGoogleActiveFolder(),
25-
"google_alloydb_cluster": alloydb.DataSourceAlloydbDatabaseCluster(),
2625
"google_alloydb_locations": alloydb.DataSourceAlloydbLocations(),
2726
"google_alloydb_supported_database_flags": alloydb.DataSourceAlloydbSupportedDatabaseFlags(),
27+
"google_alloydb_cluster": alloydb.DataSourceAlloydbDatabaseCluster(),
2828
"google_artifact_registry_docker_image": artifactregistry.DataSourceArtifactRegistryDockerImage(),
2929
"google_artifact_registry_locations": artifactregistry.DataSourceGoogleArtifactRegistryLocations(),
3030
"google_artifact_registry_repository": artifactregistry.DataSourceArtifactRegistryRepository(),
@@ -134,12 +134,12 @@ var handwrittenDatasources = map[string]*schema.Resource{
134134
"google_gke_hub_feature": gkehub2.DataSourceGoogleGkeHubFeature(),
135135
"google_filestore_instance": filestore.DataSourceGoogleFilestoreInstance(),
136136
"google_iam_policy": resourcemanager.DataSourceGoogleIamPolicy(),
137+
{{- if ne $.TargetVersionName "ga" }}
137138
"google_iam_role": resourcemanager.DataSourceGoogleIamRole(),
138139
"google_iam_testable_permissions": resourcemanager.DataSourceGoogleIamTestablePermissions(),
139-
{{- if ne $.TargetVersionName "ga" }}
140140
"google_iam_workload_identity_pool": iambeta.DataSourceIAMBetaWorkloadIdentityPool(),
141-
"google_iam_workload_identity_pool_provider": iambeta.DataSourceIAMBetaWorkloadIdentityPoolProvider(),
142141
{{- end }}
142+
"google_iam_workload_identity_pool_provider": iambeta.DataSourceIAMBetaWorkloadIdentityPoolProvider(),
143143
"google_iap_client": iap.DataSourceGoogleIapClient(),
144144
"google_kms_crypto_key": kms.DataSourceGoogleKmsCryptoKey(),
145145
"google_kms_crypto_keys": kms.DataSourceGoogleKmsCryptoKeys(),
@@ -191,9 +191,11 @@ var handwrittenDatasources = map[string]*schema.Resource{
191191
"google_parameter_manager_parameter": parametermanager.DataSourceParameterManagerParameter(),
192192
"google_parameter_manager_parameters": parametermanager.DataSourceParameterManagerParameters(),
193193
"google_parameter_manager_parameter_version": parametermanager.DataSourceParameterManagerParameterVersion(),
194+
"google_parameter_manager_parameter_version_render":parametermanager.DataSourceParameterManagerParameterVersionRender(),
194195
"google_parameter_manager_regional_parameter": parametermanagerregional.DataSourceParameterManagerRegionalRegionalParameter(),
195196
"google_parameter_manager_regional_parameters": parametermanagerregional.DataSourceParameterManagerRegionalRegionalParameters(),
196197
"google_parameter_manager_regional_parameter_version": parametermanagerregional.DataSourceParameterManagerRegionalRegionalParameterVersion(),
198+
"google_parameter_manager_regional_parameter_version_render":parametermanagerregional.DataSourceParameterManagerRegionalRegionalParameterVersionRender(),
197199
{{- end }}
198200
"google_privateca_certificate_authority": privateca.DataSourcePrivatecaCertificateAuthority(),
199201
"google_privileged_access_manager_entitlement": privilegedaccessmanager.DataSourceGooglePrivilegedAccessManagerEntitlement(),

mmv1/third_party/terraform/services/alloydb/data_soruce_alloydb_cluster_test.go renamed to mmv1/third_party/terraform/services/alloydb/data_source_alloydb_cluster_test.go

+1-11
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ func TestAccAlloydbDatabaseClusterDatasourceConfig(t *testing.T) {
1212

1313
context := map[string]interface{}{
1414
"random_suffix": acctest.RandString(t, 10),
15-
"network_name": acctest.BootstrapSharedServiceNetworkingConnection(t, "alloydb-instance-mandatory-1"),
15+
"network_name": acctest.BootstrapSharedServiceNetworkingConnection(t, "alloydb-cluster-ds"),
1616
}
1717

1818
acctest.VcrTest(t, resource.TestCase{
@@ -29,16 +29,6 @@ func TestAccAlloydbDatabaseClusterDatasourceConfig(t *testing.T) {
2929

3030
func testAccAlloydbDatabaseClusterDatasourceConfig(context map[string]interface{}) string {
3131
return acctest.Nprintf(`
32-
resource "google_alloydb_instance" "default" {
33-
cluster = google_alloydb_cluster.default.name
34-
instance_id = "tf-test-alloydb-instance%{random_suffix}"
35-
instance_type = "PRIMARY"
36-
37-
machine_config {
38-
cpu_count = 2
39-
}
40-
}
41-
4232
resource "google_alloydb_cluster" "default" {
4333
cluster_id = "tf-test-alloydb-cluster%{random_suffix}"
4434
location = "us-central1"

0 commit comments

Comments
 (0)