removed unnecessary code and addressed linting issues. Added iam3 to services_ga.kt

Author: derekchu-google

mmv1/products/iam3/PrincipalAccessBoundaryPolicy.yaml

@@ -132,9 +132,9 @@ properties:
               description: |
                 Required. A list of Cloud Resource Manager resources. The resource
                 and all the descendants are included. The number of resources in a policy
-                is limited to 500 across all rules.  
-                The following resource types are supported:  
-                * Organizations, such as `//cloudresourcemanager.googleapis.com/organizations/123`. 
+                is limited to 500 across all rules.
+                The following resource types are supported:
+                * Organizations, such as `//cloudresourcemanager.googleapis.com/organizations/123`.
                 * Folders, such as `//cloudresourcemanager.googleapis.com/folders/123`.
                 * Projects, such as `//cloudresourcemanager.googleapis.com/projects/123`
                 or `//cloudresourcemanager.googleapis.com/projects/my-project-id`.
@@ -144,7 +144,7 @@ properties:
             - name: 'effect'
               type: String
               description: |
-                Required. The access relationship of principals to the resources in this rule.   
+                Required. The access relationship of principals to the resources in this rule.
                 Possible values:  EFFECT_UNSPECIFIED ALLOW
               required: true
       - name: 'enforcementVersion'

mmv1/third_party/terraform/.teamcity/components/inputs/services_ga.kt

@@ -436,6 +436,11 @@ var ServicesListGa = mapOf(
         "displayName" to "Iam2",
         "path" to "./google/services/iam2"
     ),
+    "iam3" to mapOf(
+        "name" to "iam3",
+        "displayName" to "Iam3",
+        "path" to "./google/services/iam3"
+    ),
     "iambeta" to mapOf(
         "name" to "iambeta",
         "displayName" to "Iambeta",

mmv1/third_party/terraform/services/iam3/resource_iam3_principal_access_boundary_policy_test.go

@@ -61,6 +61,7 @@ resource "google_project" "project" {
   project_id     = "tf-test%{random_suffix}"
   name           = "tf-test%{random_suffix}"
   org_id         = "%{org_id}"
+  deletion_policy = "DELETE"
 }
 
 resource "google_iam3_principal_access_boundary_policy" "my-pab-policy" {
@@ -79,43 +80,3 @@ resource "google_iam3_principal_access_boundary_policy" "my-pab-policy" {
 }
 `, context)
 }
-
-/*
-func testAccCheckIAM3PrincipalAccessBoundaryPolicyDestroyProducer(t *testing.T) func(s *terraform.State) error {
-	return func(s *terraform.State) error {
-		for name, rs := range s.RootModule().Resources {
-			if rs.Type != "google_iam3_principal_access_boundary_policy" {
-				continue
-			}
-			if strings.HasPrefix(name, "data.") {
-				continue
-			}
-			config := acctest.GoogleProviderConfig(t)
-
-			url, err := tpgresource.ReplaceVarsForTest(config, rs, "{{IAM3BasePath}}organizations/{{organization}}/locations/{{location}}/principalAccessBoundaryPolicies/{{principal_access_boundary_policy_id}}")
-			if err != nil {
-				return err
-			}
-
-			billingProject := ""
-
-			if config.BillingProject != "" {
-				billingProject = config.BillingProject
-			}
-
-			_, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
-				Config:    config,
-				Method:    "GET",
-				Project:   billingProject,
-				RawURL:    url,
-				UserAgent: config.UserAgent,
-			})
-			if err == nil {
-				return fmt.Errorf("IAM3PrincipalAccessBoundaryPolicy still exists at %s", url)
-			}
-		}
-
-		return nil
-	}
-}
-*/