Added documentation and refactor

Author: NA2047

mmv1/third_party/terraform/provider/provider_mmv1_resources.go.tmpl

@@ -22,6 +22,7 @@ var handwrittenDatasources = map[string]*schema.Resource{
 	"google_access_approval_project_service_account":   accessapproval.DataSourceAccessApprovalProjectServiceAccount(),
 	"google_access_context_manager_access_policy":   accesscontextmanager.DataSourceAccessContextManagerAccessPolicy(),
 	"google_active_folder":                             resourcemanager.DataSourceGoogleActiveFolder(),
+	"google_alloydb_cluster":                           alloydb.DataSourceAlloydbDatabaseCluster(),
 	"google_alloydb_locations":                         alloydb.DataSourceAlloydbLocations(),
 	"google_alloydb_supported_database_flags":          alloydb.DataSourceAlloydbSupportedDatabaseFlags(),
 	"google_artifact_registry_docker_image":            artifactregistry.DataSourceArtifactRegistryDockerImage(),
@@ -190,11 +191,9 @@ var handwrittenDatasources = map[string]*schema.Resource{
 	"google_parameter_manager_parameter":               parametermanager.DataSourceParameterManagerParameter(),
 	"google_parameter_manager_parameters":              parametermanager.DataSourceParameterManagerParameters(),
 	"google_parameter_manager_parameter_version":       parametermanager.DataSourceParameterManagerParameterVersion(),
-	"google_parameter_manager_parameter_version_render":parametermanager.DataSourceParameterManagerParameterVersionRender(),
 	"google_parameter_manager_regional_parameter":      parametermanagerregional.DataSourceParameterManagerRegionalRegionalParameter(),
 	"google_parameter_manager_regional_parameters":     parametermanagerregional.DataSourceParameterManagerRegionalRegionalParameters(),
 	"google_parameter_manager_regional_parameter_version": parametermanagerregional.DataSourceParameterManagerRegionalRegionalParameterVersion(),
-	"google_parameter_manager_regional_parameter_version_render":parametermanagerregional.DataSourceParameterManagerRegionalRegionalParameterVersionRender(),
 	{{- end }}
 	"google_privateca_certificate_authority":           privateca.DataSourcePrivatecaCertificateAuthority(),
 	"google_privileged_access_manager_entitlement":     privilegedaccessmanager.DataSourceGooglePrivilegedAccessManagerEntitlement(),

mmv1/third_party/terraform/services/alloydb/data_soruce_alloydb_cluster.go

@@ -1,5 +1,3 @@
-// Copyright (c) HashiCorp, Inc.
-// SPDX-License-Identifier: MPL-2.0
 package alloydb
 
 import (
@@ -13,54 +11,37 @@ import (
 func DataSourceAlloydbDatabaseCluster() *schema.Resource {
 	// Generate datasource schema from resource
 	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(ResourceAlloydbCluster().Schema)
-	// Set custom fields
-	dsScema_cluster_id := map[string]*schema.Schema{
-		"project": {
-			Type:        schema.TypeString,
-			Optional:    true,
-			Description: `Project ID of the project.`,
-		},
-		"location": {
-			Type:        schema.TypeString,
-			Optional:    true,
-			Description: `The canonical ID for the location. For example: "us-east1".`,
-		},
-	}
-	tpgresource.AddRequiredFieldsToSchema(dsSchema, "cluster_id")
 
 	// Set 'Required' schema elements
+	tpgresource.AddRequiredFieldsToSchema(dsSchema, "cluster_id")
 
-	dsSchema_m := tpgresource.MergeSchemas(dsScema_cluster_id, dsSchema)
+	// Set 'Optional' schema elements
+	tpgresource.AddOptionalFieldsToSchema(dsSchema, "location", "project")
 
 	return &schema.Resource{
-		Read:   dataSourceAlloydbDatabaseInstanceRead,
-		Schema: dsSchema_m,
+		Read:   dataSourceAlloydbDatabaseClusterRead,
+		Schema: dsSchema,
 	}
 }
 
 func dataSourceAlloydbDatabaseClusterRead(d *schema.ResourceData, meta interface{}) error {
 	config := meta.(*transport_tpg.Config)
 
-	// Get feilds for ID for setting cluster filed in resource
-	cluster_id := d.Get("cluster_id").(string)
-
+	// Get location for setting location field in resource
 	location, err := tpgresource.GetLocation(d, config)
 	if err != nil {
 		return err
 	}
-	project, err := tpgresource.GetProject(d, config)
-	if err != nil {
-		return err
-	}
+
 	// Store the ID now
 	id, err := tpgresource.ReplaceVars(d, config, "projects/{{project}}/locations/{{location}}/clusters/{{cluster_id}}")
 	if err != nil {
 		return fmt.Errorf("Error constructing id: %s", err)
 	}
 	d.SetId(id)
 
-	// Setting cluster field
-	d.Set("cluster", fmt.Sprintf("projects/%s/locations/%s/clusters/%s", project, location, cluster_id))
+	// Setting location field as this is set as a required field in cluster resource
+	d.Set("location", location)
 
 	err = resourceAlloydbClusterRead(d, meta)
 	if err != nil {

mmv1/third_party/terraform/services/alloydb/data_soruce_alloydb_cluster_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/hashicorp/terraform-provider-google/google/acctest"
 )
 
-func TestAccAlloydbDatabaseInstanceDatasourceConfig(t *testing.T) {
+func TestAccAlloydbDatabaseClusterDatasourceConfig(t *testing.T) {
 	t.Parallel()
 
 	context := map[string]interface{}{
@@ -27,7 +27,7 @@ func TestAccAlloydbDatabaseInstanceDatasourceConfig(t *testing.T) {
 	})
 }
 
-func testAccAlloydbDatabaseInstanceDatasourceConfig(context map[string]interface{}) string {
+func testAccAlloydbDatabaseClusterDatasourceConfig(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 resource "google_alloydb_instance" "default" {
   cluster       = google_alloydb_cluster.default.name

mmv1/third_party/terraform/website/docs/d/alloydb_cluster.html.markdown

@@ -0,0 +1,38 @@
+---
+subcategory: "AlloyDB"
+description: |-
+  Fetches the details of available cluster.
+---
+
+# google_alloydb_cluster
+
+Use this data source to get information about the available cluster. For more details refer the [API docs](https://cloud.google.com/alloydb/docs/reference/rest/v1/projects.locations.clusters).
+
+## Example Usage
+
+
+```hcl
+data "google_alloydb_cluster" "qa" {
+}
+```
+
+## Argument Reference
+
+The following arguments are supported:
+
+* `cluster_id` -
+  (Required)
+  The ID of the alloydb cluster that the instance belongs to.
+  'alloydb_cluster_id'
+
+* `project` - 
+  (optional) 
+  The ID of the project in which the resource belongs. If it is not provided, the provider project is used.
+
+* `location` -
+  (optional)
+  The canonical id of the location.If it is not provided, the provider project is used. For example: us-east1.
+
+## Attributes Reference
+
+See [google_alloydb_cluster](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/alloydb_cluster) resource for details of all the available attributes.