Skip to content

Commit 1c344ad

Browse files
Add support for setting Pub/Sub Cloud Storage subscription max_messages and use_topic_schema (#11583) (#2739)
[upstream:692bae292bf8c33f8443e60cc53bab800b4821a2] Signed-off-by: Modular Magician <[email protected]>
1 parent 34956a1 commit 1c344ad

File tree

3 files changed

+25
-3
lines changed

3 files changed

+25
-3
lines changed

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ require (
1111
github.com/hashicorp/hcl/v2 v2.20.1
1212
github.com/hashicorp/terraform-json v0.22.1
1313
github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0
14-
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240830195521-72eebccb9cee
14+
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240902085432-242b58f75953
1515
github.com/mitchellh/go-homedir v1.1.0 // indirect
1616
github.com/pkg/errors v0.9.1
1717
github.com/stretchr/testify v1.9.0

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@ github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0 h1:qHprzXy/As0rxedphECBEQAh
190190
github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0/go.mod h1:H+8tjs9TjV2w57QFVSMBQacf8k/E1XwLXGCARgViC6A=
191191
github.com/hashicorp/terraform-plugin-testing v1.5.1 h1:T4aQh9JAhmWo4+t1A7x+rnxAJHCDIYW9kXyo4sVO92c=
192192
github.com/hashicorp/terraform-plugin-testing v1.5.1/go.mod h1:dg8clO6K59rZ8w9EshBmDp1CxTIPu3yA4iaDpX1h5u0=
193-
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240830195521-72eebccb9cee h1:1nitOv2l26VHyroA6Sil0LfILeYaWEDTOV7xCWmQcZ4=
194-
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240830195521-72eebccb9cee/go.mod h1:UweFt1y4JaSHAS8NtceJLCaaMy4j68gJwEo9sCaswG8=
193+
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240902085432-242b58f75953 h1:3TK93LVIPgg/waUICErNfkHNVLRL+AcqgPN+TCGdnzw=
194+
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240902085432-242b58f75953/go.mod h1:UweFt1y4JaSHAS8NtceJLCaaMy4j68gJwEo9sCaswG8=
195195
github.com/hashicorp/terraform-registry-address v0.2.3 h1:2TAiKJ1A3MAkZlH1YI/aTVcLZRu7JseiXNRHbOAyoTI=
196196
github.com/hashicorp/terraform-registry-address v0.2.3/go.mod h1:lFHA76T8jfQteVfT7caREqguFrW3c4MFSPhZB7HHgUM=
197197
github.com/hashicorp/terraform-svchost v0.1.1 h1:EZZimZ1GxdqFRinZ1tpJwVxxt49xc/S52uzrw4x0jKQ=

tfplan2cai/converters/google/resources/services/pubsub/pubsub_subscription.go

+22
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,13 @@ func expandPubsubSubscriptionCloudStorageConfig(v interface{}, d tpgresource.Ter
349349
transformed["maxBytes"] = transformedMaxBytes
350350
}
351351

352+
transformedMaxMessages, err := expandPubsubSubscriptionCloudStorageConfigMaxMessages(original["max_messages"], d, config)
353+
if err != nil {
354+
return nil, err
355+
} else if val := reflect.ValueOf(transformedMaxMessages); val.IsValid() && !tpgresource.IsEmptyValue(val) {
356+
transformed["maxMessages"] = transformedMaxMessages
357+
}
358+
352359
transformedState, err := expandPubsubSubscriptionCloudStorageConfigState(original["state"], d, config)
353360
if err != nil {
354361
return nil, err
@@ -397,6 +404,10 @@ func expandPubsubSubscriptionCloudStorageConfigMaxBytes(v interface{}, d tpgreso
397404
return v, nil
398405
}
399406

407+
func expandPubsubSubscriptionCloudStorageConfigMaxMessages(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
408+
return v, nil
409+
}
410+
400411
func expandPubsubSubscriptionCloudStorageConfigState(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
401412
return v, nil
402413
}
@@ -417,13 +428,24 @@ func expandPubsubSubscriptionCloudStorageConfigAvroConfig(v interface{}, d tpgre
417428
transformed["writeMetadata"] = transformedWriteMetadata
418429
}
419430

431+
transformedUseTopicSchema, err := expandPubsubSubscriptionCloudStorageConfigAvroConfigUseTopicSchema(original["use_topic_schema"], d, config)
432+
if err != nil {
433+
return nil, err
434+
} else if val := reflect.ValueOf(transformedUseTopicSchema); val.IsValid() && !tpgresource.IsEmptyValue(val) {
435+
transformed["useTopicSchema"] = transformedUseTopicSchema
436+
}
437+
420438
return transformed, nil
421439
}
422440

423441
func expandPubsubSubscriptionCloudStorageConfigAvroConfigWriteMetadata(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
424442
return v, nil
425443
}
426444

445+
func expandPubsubSubscriptionCloudStorageConfigAvroConfigUseTopicSchema(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
446+
return v, nil
447+
}
448+
427449
func expandPubsubSubscriptionCloudStorageConfigServiceAccountEmail(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
428450
return v, nil
429451
}

0 commit comments

Comments
 (0)