Skip to content

Commit 8da12ca

Browse files
Revert "Etag support for ACM service perimeters" (#12568) (#3209)
[upstream:87f392596aa1431322e8f341011561e171e2329f] Signed-off-by: Modular Magician <[email protected]>
1 parent 8416950 commit 8da12ca

File tree

4 files changed

+3
-24
lines changed

4 files changed

+3
-24
lines changed

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ require (
1111
github.com/hashicorp/hcl/v2 v2.20.1
1212
github.com/hashicorp/terraform-json v0.22.1
1313
github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0
14-
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241213180537-423d69885214
14+
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241213201446-f86a0265d199
1515
github.com/mitchellh/go-homedir v1.1.0 // indirect
1616
github.com/pkg/errors v0.9.1
1717
github.com/stretchr/testify v1.9.0

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@ github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0 h1:qHprzXy/As0rxedphECBEQAh
190190
github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0/go.mod h1:H+8tjs9TjV2w57QFVSMBQacf8k/E1XwLXGCARgViC6A=
191191
github.com/hashicorp/terraform-plugin-testing v1.5.1 h1:T4aQh9JAhmWo4+t1A7x+rnxAJHCDIYW9kXyo4sVO92c=
192192
github.com/hashicorp/terraform-plugin-testing v1.5.1/go.mod h1:dg8clO6K59rZ8w9EshBmDp1CxTIPu3yA4iaDpX1h5u0=
193-
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241213180537-423d69885214 h1:U5g/oQsBwNGV2BcpxEboVz4h/onTnhXUm1cPaPgRoXQ=
194-
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241213180537-423d69885214/go.mod h1:+3tdRXgcI0aDAIH8vCVW2qAfcn7JiGlEv8RGuQJp6yY=
193+
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241213201446-f86a0265d199 h1:CN7zV5craU5X0zVX2sTQSWYkcSZAOASpkAwSG4bR/ho=
194+
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241213201446-f86a0265d199/go.mod h1:+3tdRXgcI0aDAIH8vCVW2qAfcn7JiGlEv8RGuQJp6yY=
195195
github.com/hashicorp/terraform-registry-address v0.2.3 h1:2TAiKJ1A3MAkZlH1YI/aTVcLZRu7JseiXNRHbOAyoTI=
196196
github.com/hashicorp/terraform-registry-address v0.2.3/go.mod h1:lFHA76T8jfQteVfT7caREqguFrW3c4MFSPhZB7HHgUM=
197197
github.com/hashicorp/terraform-svchost v0.1.1 h1:EZZimZ1GxdqFRinZ1tpJwVxxt49xc/S52uzrw4x0jKQ=

tfplan2cai/converters/google/resources/services/accesscontextmanager/accesscontextmanager_service_perimeter.go

-10
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,6 @@ func GetAccessContextManagerServicePerimeterApiObject(d tpgresource.TerraformRes
145145
} else if v, ok := d.GetOkExists("use_explicit_dry_run_spec"); !tpgresource.IsEmptyValue(reflect.ValueOf(useExplicitDryRunSpecProp)) && (ok || !reflect.DeepEqual(v, useExplicitDryRunSpecProp)) {
146146
obj["useExplicitDryRunSpec"] = useExplicitDryRunSpecProp
147147
}
148-
etagProp, err := expandAccessContextManagerServicePerimeterEtag(d.Get("etag"), d, config)
149-
if err != nil {
150-
return nil, err
151-
} else if v, ok := d.GetOkExists("etag"); !tpgresource.IsEmptyValue(reflect.ValueOf(etagProp)) && (ok || !reflect.DeepEqual(v, etagProp)) {
152-
obj["etag"] = etagProp
153-
}
154148
parentProp, err := expandAccessContextManagerServicePerimeterParent(d.Get("parent"), d, config)
155149
if err != nil {
156150
return nil, err
@@ -1256,10 +1250,6 @@ func expandAccessContextManagerServicePerimeterUseExplicitDryRunSpec(v interface
12561250
return v, nil
12571251
}
12581252

1259-
func expandAccessContextManagerServicePerimeterEtag(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
1260-
return v, nil
1261-
}
1262-
12631253
func expandAccessContextManagerServicePerimeterParent(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
12641254
return v, nil
12651255
}

tfplan2cai/converters/google/resources/services/accesscontextmanager/accesscontextmanager_service_perimeters.go

-11
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,6 @@ func expandAccessContextManagerServicePerimetersServicePerimeters(v interface{},
103103
transformed["description"] = transformedDescription
104104
}
105105

106-
transformedEtag, err := expandAccessContextManagerServicePerimetersServicePerimetersEtag(original["etag"], d, config)
107-
if err != nil {
108-
return nil, err
109-
} else if val := reflect.ValueOf(transformedEtag); val.IsValid() && !tpgresource.IsEmptyValue(val) {
110-
transformed["etag"] = transformedEtag
111-
}
112-
113106
transformedCreateTime, err := expandAccessContextManagerServicePerimetersServicePerimetersCreateTime(original["create_time"], d, config)
114107
if err != nil {
115108
return nil, err
@@ -169,10 +162,6 @@ func expandAccessContextManagerServicePerimetersServicePerimetersDescription(v i
169162
return v, nil
170163
}
171164

172-
func expandAccessContextManagerServicePerimetersServicePerimetersEtag(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
173-
return v, nil
174-
}
175-
176165
func expandAccessContextManagerServicePerimetersServicePerimetersCreateTime(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
177166
return v, nil
178167
}

0 commit comments

Comments
 (0)