compute: used net.IP.Equal vs bytes.Equal for IP comparison (#12279) (#3059)

modular-magician · web-flow · commit 93138ec8e955 · 2024-11-08T10:26:44.000-08:00
[upstream:43b84b7308128de70332e50ff85c5f3713f66c1b]

Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/tfplan2cai/converters/google/resources/services/compute/compute_forwarding_rule.go b/tfplan2cai/converters/google/resources/services/compute/compute_forwarding_rule.go
@@ -15,7 +15,6 @@
 package compute
 
 import (
-	"bytes"
 	"context"
 	"fmt"
 	"log"
@@ -83,7 +82,7 @@ func InternalIpDiffSuppress(_, old, new string, _ *schema.ResourceData) bool {
 			addr_equality = true
 		} else {
 			// old and new are IP addresses
-			addr_equality = bytes.Equal(addr_old, addr_new)
+			addr_equality = net.IP.Equal(addr_old, addr_new)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`	`package compute`
`16`	`16`
`17`	`17`	`import (`
`18`		`- "bytes"`
`19`	`18`	`"context"`
`20`	`19`	`"fmt"`
`21`	`20`	`"log"`
`@@ -83,7 +82,7 @@ func InternalIpDiffSuppress(_, old, new string, _ *schema.ResourceData) bool {`
`83`	`82`	`addr_equality = true`
`84`	`83`	`} else {`
`85`	`84`	`// old and new are IP addresses`
`86`		`- addr_equality = bytes.Equal(addr_old, addr_new)`
	`85`	`+ addr_equality = net.IP.Equal(addr_old, addr_new)`
`87`	`86`	`}`
`88`	`87`	`}`
`89`	`88`