Skip to content

Commit ce2b8fc

Browse files
Enable usage of flags related to instance mode and instance endpoints. (#12079) (#2976)
[upstream:cd75b5ffe373645fd4fa434b756bde89b4094740] Signed-off-by: Modular Magician <[email protected]>
1 parent 980d88e commit ce2b8fc

File tree

3 files changed

+16
-6
lines changed

3 files changed

+16
-6
lines changed

go.mod

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ require (
1111
github.com/hashicorp/hcl/v2 v2.20.1
1212
github.com/hashicorp/terraform-json v0.22.1
1313
github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0
14-
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241023162243-36a886f67d2a
14+
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241023174225-9b38e3a71f81
1515
github.com/mitchellh/go-homedir v1.1.0 // indirect
1616
github.com/pkg/errors v0.9.1
1717
github.com/stretchr/testify v1.9.0
@@ -33,7 +33,7 @@ require (
3333
cloud.google.com/go/iam v1.2.1 // indirect
3434
cloud.google.com/go/longrunning v0.6.1 // indirect
3535
cloud.google.com/go/monitoring v1.21.1 // indirect
36-
github.com/GoogleCloudPlatform/declarative-resource-client-library v1.74.0 // indirect
36+
github.com/GoogleCloudPlatform/declarative-resource-client-library v1.75.0 // indirect
3737
github.com/ProtonMail/go-crypto v1.1.0-alpha.2 // indirect
3838
github.com/agext/levenshtein v1.2.3 // indirect
3939
github.com/apparentlymart/go-textseg/v15 v15.0.0 // indirect

go.sum

+4-4
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ cloud.google.com/go/monitoring v1.21.1/go.mod h1:Rj++LKrlht9uBi8+Eb530dIrzG/cU/l
2222
dario.cat/mergo v1.0.0 h1:AGCNq9Evsj31mOgNPcLyXc+4PNABt905YmuqPYYpBWk=
2323
dario.cat/mergo v1.0.0/go.mod h1:uNxQE+84aUszobStD9th8a29P2fMDhsBdgRYvZOxGmk=
2424
github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
25-
github.com/GoogleCloudPlatform/declarative-resource-client-library v1.74.0 h1:YV3eTXgDw3Zp8Mc12WE2Aa3+22twNd07xkFkEODrlOQ=
26-
github.com/GoogleCloudPlatform/declarative-resource-client-library v1.74.0/go.mod h1:pL2Qt5HT+x6xrTd806oMiM3awW6kNIXB/iiuClz6m6k=
25+
github.com/GoogleCloudPlatform/declarative-resource-client-library v1.75.0 h1:7tFkHNjfjm7dYnjqyuzMon+31lPaMTjca3OuamWd0Oo=
26+
github.com/GoogleCloudPlatform/declarative-resource-client-library v1.75.0/go.mod h1:pL2Qt5HT+x6xrTd806oMiM3awW6kNIXB/iiuClz6m6k=
2727
github.com/Microsoft/go-winio v0.6.1 h1:9/kr64B9VUZrLm5YYwbGtUJnMgqWVOdUAXu6Migciow=
2828
github.com/Microsoft/go-winio v0.6.1/go.mod h1:LRdKpFKfdobln8UmuiYcKPot9D2v6svN5+sAH+4kjUM=
2929
github.com/ProtonMail/go-crypto v1.1.0-alpha.2 h1:bkyFVUP+ROOARdgCiJzNQo2V2kiB97LyUpzH9P6Hrlg=
@@ -190,8 +190,8 @@ github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0 h1:qHprzXy/As0rxedphECBEQAh
190190
github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0/go.mod h1:H+8tjs9TjV2w57QFVSMBQacf8k/E1XwLXGCARgViC6A=
191191
github.com/hashicorp/terraform-plugin-testing v1.5.1 h1:T4aQh9JAhmWo4+t1A7x+rnxAJHCDIYW9kXyo4sVO92c=
192192
github.com/hashicorp/terraform-plugin-testing v1.5.1/go.mod h1:dg8clO6K59rZ8w9EshBmDp1CxTIPu3yA4iaDpX1h5u0=
193-
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241023162243-36a886f67d2a h1:2XxWnxTMAUEqCUQtDU7Zf1CbIb/pNvkl3wtWtpqUJos=
194-
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241023162243-36a886f67d2a/go.mod h1:pyARo9QYRsIUJPI2cSNNmWOl0GWVv/GIh963GyEZyzU=
193+
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241023174225-9b38e3a71f81 h1:1mu0tzt5E/7ZfSHIW/vg+H7VLQQyNbo2E/B+GawEs+8=
194+
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20241023174225-9b38e3a71f81/go.mod h1:cKf7MeE/qanRHVGkTYwcNBiNs1Bt2PDr3HV95sYbkOQ=
195195
github.com/hashicorp/terraform-registry-address v0.2.3 h1:2TAiKJ1A3MAkZlH1YI/aTVcLZRu7JseiXNRHbOAyoTI=
196196
github.com/hashicorp/terraform-registry-address v0.2.3/go.mod h1:lFHA76T8jfQteVfT7caREqguFrW3c4MFSPhZB7HHgUM=
197197
github.com/hashicorp/terraform-svchost v0.1.1 h1:EZZimZ1GxdqFRinZ1tpJwVxxt49xc/S52uzrw4x0jKQ=

tfplan2cai/converters/google/resources/services/memorystore/memorystore_instance.go

+10
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,12 @@ func GetMemorystoreInstanceApiObject(d tpgresource.TerraformResourceData, config
114114
} else if v, ok := d.GetOkExists("deletion_protection_enabled"); !tpgresource.IsEmptyValue(reflect.ValueOf(deletionProtectionEnabledProp)) && (ok || !reflect.DeepEqual(v, deletionProtectionEnabledProp)) {
115115
obj["deletionProtectionEnabled"] = deletionProtectionEnabledProp
116116
}
117+
modeProp, err := expandMemorystoreInstanceMode(d.Get("mode"), d, config)
118+
if err != nil {
119+
return nil, err
120+
} else if v, ok := d.GetOkExists("mode"); !tpgresource.IsEmptyValue(reflect.ValueOf(modeProp)) && (ok || !reflect.DeepEqual(v, modeProp)) {
121+
obj["mode"] = modeProp
122+
}
117123
labelsProp, err := expandMemorystoreInstanceEffectiveLabels(d.Get("effective_labels"), d, config)
118124
if err != nil {
119125
return nil, err
@@ -321,6 +327,10 @@ func expandMemorystoreInstanceDeletionProtectionEnabled(v interface{}, d tpgreso
321327
return v, nil
322328
}
323329

330+
func expandMemorystoreInstanceMode(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
331+
return v, nil
332+
}
333+
324334
func expandMemorystoreInstanceEffectiveLabels(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (map[string]string, error) {
325335
if v == nil {
326336
return map[string]string{}, nil

0 commit comments

Comments
 (0)