release: v1.34.0 (#6770)

nkubala · web-flow · commit 22cfab75ffb3 · 2021-10-26T17:20:49.000-07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,59 @@
+# v1.34.0 Release - 10/26/2021
+**Linux**
+`curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v1.34.0/skaffold-linux-amd64 && chmod +x skaffold && sudo mv skaffold /usr/local/bin`
+
+**macOS**
+`curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v1.34.0/skaffold-darwin-amd64 && chmod +x skaffold && sudo mv skaffold /usr/local/bin`
+
+**Windows**
+https://storage.googleapis.com/skaffold/releases/v1.34.0/skaffold-windows-amd64.exe
+
+**Docker image**
+`gcr.io/k8s-skaffold/skaffold:v1.34.0`
+
+Note: This release comes with a new config version, `v2beta25`. To upgrade your skaffold.yaml, use `skaffold fix`. If you choose not to upgrade, skaffold will auto-upgrade as best as it can.
+
+Highlights:
+* `skaffold deploy`, `skaffold render` and `skaffold test` now support the `--images` flag for providing a list of images to run against.
+* The `--images` flag now supports `NAME=TAG` pairs.
+
+New Features and Additions:
+* feat: trap SIGUSR1 to dump current stacktrace [#6751](https://github.com/GoogleContainerTools/skaffold/pull/6751)
+* feat: skaffold lint core logic, CLI command+flags, and MVP skaffold.yaml support [#6715](https://github.com/GoogleContainerTools/skaffold/pull/6715)
+
+Fixes:
+* fix: fix non-determinism in skaffoldyamls_test.go [#6757](https://github.com/GoogleContainerTools/skaffold/pull/6757)
+* fix: use new stringslice lib [#6752](https://github.com/GoogleContainerTools/skaffold/pull/6752)
+* fix: correctly rewrite debug container entrypoint and bind host port [#6682](https://github.com/GoogleContainerTools/skaffold/pull/6682)
+* Fix new version generation [#6616](https://github.com/GoogleContainerTools/skaffold/pull/6616)
+* fix: panic caused by multiple channel closes [#6714](https://github.com/GoogleContainerTools/skaffold/pull/6714)
+* fix: sanity check kpt deployer versions [#6711](https://github.com/GoogleContainerTools/skaffold/pull/6711)
+
+Updates and Refactors:
+* refactor: move some of `pkg/skaffold/util` into into packages [#6731](https://github.com/GoogleContainerTools/skaffold/pull/6731)
+
+Docs, Test, and Release Updates:
+* doc: update CI-CD article to decouple `render` and `deploy` use from GitOps [#6750](https://github.com/GoogleContainerTools/skaffold/pull/6750)
+* chore: update image dependencies [#6736](https://github.com/GoogleContainerTools/skaffold/pull/6736)
+* chore: use ad-hoc signing on darwin to avoid network popups [#6738](https://github.com/GoogleContainerTools/skaffold/pull/6738)
+* chore: add cluster type to the instrumentation meter [#6734](https://github.com/GoogleContainerTools/skaffold/pull/6734)
+* chore: Update globstar syntax in examples dependencies [#6614](https://github.com/GoogleContainerTools/skaffold/pull/6614)
+* docs: add Cloud Code install instructions [#6716](https://github.com/GoogleContainerTools/skaffold/pull/6716)
+
+Huge thanks goes out to all of our contributors for this release:
+
+- Aaron Prindle
+- Brian de Alwis
+- Conor A. Callahan
+- Dave Dorbin
+- Gaurav
+- Halvard Skogsrud
+- Marlon Gamez
+- Mike Verbanic
+- Nick Kubala
+- Tejal Desai
+- Yuwen Ma
+
 # v1.33.0 Release - 10/07/2021
 **Linux**
 `curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v1.33.0/skaffold-linux-amd64 && chmod +x skaffold && sudo mv skaffold /usr/local/bin`
diff --git a/examples/bazel/skaffold.yaml b/examples/bazel/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/buildpacks-java/skaffold.yaml b/examples/buildpacks-java/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/buildpacks-node/skaffold.yaml b/examples/buildpacks-node/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/buildpacks-python/skaffold.yaml b/examples/buildpacks-python/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/buildpacks/skaffold.yaml b/examples/buildpacks/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/custom-buildx/skaffold.yaml b/examples/custom-buildx/skaffold.yaml
@@ -1,12 +1,14 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
-
 build:
   artifacts:
   - image: skaffold-examples-buildx
     custom:
       buildCommand: sh buildx.sh
       dependencies:
-        paths: ["go.mod", "**.go", "buildx.sh"]
+        paths:
+        - "**/*.go"
+        - buildx.sh
+        - go.mod
   tagPolicy:
     sha256: {}
diff --git a/examples/custom-tests/skaffold.yaml b/examples/custom-tests/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/custom/.ko.yaml b/examples/custom/.ko.yaml
@@ -0,0 +1 @@
+defaultBaseImage: gcr.io/distroless/static:nonroot
diff --git a/examples/custom/README.md b/examples/custom/README.md
@@ -20,38 +20,45 @@ This tutorial will demonstrate how Skaffold can build a simple Hello World Go ap
 
 First, clone the Skaffold [repo](https://github.com/GoogleContainerTools/skaffold) and navigate to the [custom example](https://github.com/GoogleContainerTools/skaffold/tree/main/examples/custom) for sample code:
 
-```shell
-$ git clone https://github.com/GoogleContainerTools/skaffold
-$ cd skaffold/examples/custom
+```sh
+git clone https://github.com/GoogleContainerTools/skaffold.git
+```
+```sh
+cd skaffold/examples/custom
 ```
 
 Take a look at the `build.sh` file, which uses `ko` to containerize source code:
 
-```shell
-$ cat build.sh
+[embedmd]:# (build.sh bash)
+```bash
 #!/usr/bin/env bash
 set -e
+set -x
 
-if ! [ -x "$(command -v ko)" ]; then
+if ! [ -x "$(go env GOPATH)/bin/ko" ]; then
     pushd $(mktemp -d)
-    go mod init tmp; GOFLAGS= go get github.com/google/ko/cmd/ko@v0.6.0
+    curl -L https://github.com/google/ko/archive/v0.9.3.tar.gz | tar --strip-components 1 -zx
+    go build -o $(go env GOPATH)/bin/ko .
     popd
 fi
 
-output=$(ko publish --local --preserve-import-paths --tags= . | tee)
-ref=$(echo $output | tail -n1)
+output=$($(go env GOPATH)/bin/ko publish --local --preserve-import-paths --tags= . | tee)
+ref=$(echo "$output" | tail -n1)
 
-docker tag $ref $IMAGE
-if $PUSH_IMAGE; then
-    docker push $IMAGE
+docker tag "$ref" "$IMAGE"
+if [[ "${PUSH_IMAGE}" == "true" ]]; then
+    echo "Pushing $IMAGE"
+    docker push "$IMAGE"
+else
+    echo "Not pushing $IMAGE"
 fi
 ```
 
 and the skaffold config, which configures image `ko://github.com/GoogleContainerTools/skaffold/examples/custom` to build with `build.sh`:
 
+[embedmd]:# (skaffold.yaml yaml)
 ```yaml
-$ cat skaffold.yaml
-apiVersion: skaffold/v2beta9
+apiVersion: skaffold/v2beta24
 kind: Config
 build:
   artifacts:
@@ -60,32 +67,33 @@ build:
       buildCommand: ./build.sh
       dependencies:
         paths:
-        - "go.mod"
-        - "**.go"
+        - "**/*.go"
+        - go.mod
+        - .ko.yaml
   tagPolicy:
     sha256: {}
 ```
 
 The `k8s/pod.yaml` manifest file uses the same image reference:
 
+[embedmd]:# (k8s/pod.yaml yaml)
 ```yaml
-$ cat k8s/pod.yaml
 apiVersion: v1
 kind: Pod
 metadata:
-  name: getting-started
+  name: getting-started-custom
 spec:
   containers:
-  - name: getting-started
+  - name: getting-started-custom
     image: ko://github.com/GoogleContainerTools/skaffold/examples/custom
 ```
 
 For more information about how this works, see the Skaffold custom builder [documentation](https://skaffold.dev/docs/how-tos/builders/#custom-build-script-run-locally).
 
 Now, use Skaffold to deploy this application to your Kubernetes cluster:
 
-```shell
-$ skaffold run --tail --default-repo <your repo>
+```sh
+skaffold run --tail --default-repo <your repo>
 ```
 
 With this command, Skaffold will build the `github.com/googlecontainertools/skaffold/examples/custom` artifact with ko and deploy the application to Kubernetes.
@@ -95,6 +103,6 @@ You should be able to see *Hello, World!* printed every second in the Skaffold l
 
 To clean up your Kubernetes cluster, run:
 
-```shell
-$ skaffold delete
+```sh
+skaffold delete
 ```
diff --git a/examples/custom/build.sh b/examples/custom/build.sh
@@ -1,9 +1,10 @@
 #!/usr/bin/env bash
 set -e
+set -x
 
 if ! [ -x "$(go env GOPATH)/bin/ko" ]; then
     pushd $(mktemp -d)
-    curl -L https://github.com/google/ko/archive/v0.8.3.tar.gz | tar --strip-components 1 -zx
+    curl -L https://github.com/google/ko/archive/v0.9.3.tar.gz | tar --strip-components 1 -zx
     go build -o $(go env GOPATH)/bin/ko .
     popd
 fi
diff --git a/examples/custom/skaffold.yaml b/examples/custom/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
@@ -7,7 +7,8 @@ build:
       buildCommand: ./build.sh
       dependencies:
         paths:
-        - "go.mod"
-        - "**.go"
+        - "**/*.go"
+        - go.mod
+        - .ko.yaml
   tagPolicy:
     sha256: {}
diff --git a/examples/dev-journey-buildpacks/skaffold.yaml b/examples/dev-journey-buildpacks/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/docker-deploy/skaffold.yaml b/examples/docker-deploy/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   local:
diff --git a/examples/gcb-kaniko/skaffold.yaml b/examples/gcb-kaniko/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   googleCloudBuild:
diff --git a/examples/generate-pipeline/skaffold.yaml b/examples/generate-pipeline/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/getting-started-kustomize/skaffold.yaml b/examples/getting-started-kustomize/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 metadata:
   name: getting-started-kustomize
diff --git a/examples/getting-started/skaffold.yaml b/examples/getting-started/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/google-cloud-build/skaffold.yaml b/examples/google-cloud-build/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   googleCloudBuild:
diff --git a/examples/helm-deployment-dependencies/skaffold.yaml b/examples/helm-deployment-dependencies/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   tagPolicy:
diff --git a/examples/helm-deployment/skaffold.yaml b/examples/helm-deployment/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/helm-remote-repo/skaffold.yaml b/examples/helm-remote-repo/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 deploy:
   helm:
diff --git a/examples/hot-reload/skaffold.yaml b/examples/hot-reload/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/jib-gradle/skaffold.yaml b/examples/jib-gradle/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/jib-multimodule/skaffold.yaml b/examples/jib-multimodule/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/jib-sync/skaffold-gradle.yaml b/examples/jib-sync/skaffold-gradle.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/jib-sync/skaffold-maven.yaml b/examples/jib-sync/skaffold-maven.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/jib/skaffold.yaml b/examples/jib/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/kaniko/skaffold.yaml b/examples/kaniko/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/kustomize/skaffold-kustomize-args.yaml b/examples/kustomize/skaffold-kustomize-args.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 deploy:
   kustomize:
diff --git a/examples/kustomize/skaffold.yaml b/examples/kustomize/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 deploy:
   kustomize: {}
diff --git a/examples/lifecycle-hooks/skaffold.yaml b/examples/lifecycle-hooks/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/microservices/skaffold.yaml b/examples/microservices/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/multi-config-microservices/base/skaffold.yaml b/examples/multi-config-microservices/base/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 build:
   artifacts:
diff --git a/examples/multi-config-microservices/leeroy-app/skaffold.yaml b/examples/multi-config-microservices/leeroy-app/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 metadata:
   name: app-config
diff --git a/examples/multi-config-microservices/leeroy-web/skaffold.yaml b/examples/multi-config-microservices/leeroy-web/skaffold.yaml
@@ -1,4 +1,4 @@
-apiVersion: skaffold/v2beta24
+apiVersion: skaffold/v2beta25
 kind: Config
 metadata:
   name: web-config
diff --git a/examples/multi-config-microservices/skaffold.yaml b/examples/multi-config-microservices/skaffold.yaml
diff --git a/examples/nodejs/skaffold.yaml b/examples/nodejs/skaffold.yaml
diff --git a/examples/profile-patches/skaffold.yaml b/examples/profile-patches/skaffold.yaml
diff --git a/examples/profiles/skaffold.yaml b/examples/profiles/skaffold.yaml
diff --git a/examples/react-reload-docker/skaffold.yaml b/examples/react-reload-docker/skaffold.yaml
diff --git a/examples/react-reload/skaffold.yaml b/examples/react-reload/skaffold.yaml
diff --git a/examples/remote-multi-config-microservices/skaffold.yaml b/examples/remote-multi-config-microservices/skaffold.yaml
diff --git a/examples/ruby/backend/Gemfile.lock b/examples/ruby/backend/Gemfile.lock
diff --git a/examples/ruby/skaffold.yaml b/examples/ruby/skaffold.yaml
diff --git a/examples/simple-artifact-dependency/skaffold.yaml b/examples/simple-artifact-dependency/skaffold.yaml
diff --git a/examples/structure-tests/skaffold.yaml b/examples/structure-tests/skaffold.yaml
diff --git a/examples/tagging-with-environment-variables/skaffold.yaml b/examples/tagging-with-environment-variables/skaffold.yaml
diff --git a/examples/templated-fields/README.md b/examples/templated-fields/README.md
diff --git a/examples/templated-fields/build.sh b/examples/templated-fields/build.sh
diff --git a/examples/templated-fields/skaffold.yaml b/examples/templated-fields/skaffold.yaml
diff --git a/examples/typescript/skaffold.yaml b/examples/typescript/skaffold.yaml
diff --git a/pkg/skaffold/schema/latest/v1/config.go b/pkg/skaffold/schema/latest/v1/config.go

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-apiVersion: skaffold/v2beta24`
	`1`	`+apiVersion: skaffold/v2beta25`
`2`	`2`	`kind: Config`
`3`	`3`	`build:`
`4`	`4`	`artifacts:`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+defaultBaseImage: gcr.io/distroless/static:nonroot`