fix: apply cmd should run kubectl create --dry-run to get the ManifestList (#6875)

Author: gsquared94

integration/apply_test.go

@@ -95,6 +95,10 @@ func TestApplyStatusCheckFailure(t *testing.T) {
 			description: "status check for config connector resources",
 			profile:     "configconnector",
 		},
+		{
+			description: "status check for standalone pods",
+			profile:     "pod",
+		},
 	}
 	for _, test := range tests {
 		testutil.Run(t, test.description, func(t *testutil.T) {

integration/testdata/apply/pod.yaml

@@ -0,0 +1,8 @@
+apiVersion: v1
+kind: Pod
+metadata:
+  name: zz-image-doesnt-exist
+spec:
+  containers:
+  - image: zz-image-doesnt-exist
+    name: apply-status-check-failure

integration/testdata/apply/skaffold.yaml

@@ -14,3 +14,7 @@ profiles:
       kubectl:
         statusCheckDeadlineSeconds: 10
         manifests: ["configconnector.yaml"]
+  - name: pod
+    deploy:
+      kubectl:
+        manifests: ["pod.yaml"]

pkg/skaffold/deploy/kubectl/kubectl.go

@@ -180,8 +180,8 @@ func (k *Deployer) Deploy(ctx context.Context, out io.Writer, builds []graph.Art
 	// also, manually set the labels to ensure the runID is added
 	switch {
 	case len(k.hydratedManifests) > 0:
-		_, endTrace = instrumentation.StartTrace(ctx, "Deploy_createManifestList")
-		manifests, err = createManifestList(k.hydratedManifests)
+		_, endTrace = instrumentation.StartTrace(ctx, "Deploy_readHydratedManifests")
+		manifests, err = k.kubectl.ReadManifests(ctx, k.hydratedManifests)
 		if err != nil {
 			endTrace(instrumentation.TraceEndError(err))
 			return err