Upgrade the linter

Signed-off-by: David Gageot <[email protected]>

Author: dgageot

cmd/skaffold/app/cmd/completion.go

@@ -246,11 +246,10 @@ func NewCmdCompletion(out io.Writer) *cobra.Command {
 	return completionCmd
 }
 
-func runCompletionZsh(out io.Writer) error {
+func runCompletionZsh(out io.Writer) {
 	io.WriteString(out, zshInitialization)
 	buf := new(bytes.Buffer)
 	rootCmd.GenBashCompletion(buf)
 	out.Write(buf.Bytes())
 	io.WriteString(out, zshTail)
-	return nil
 }

cmd/skaffold/app/cmd/runner.go

@@ -57,9 +57,7 @@ func newRunner(opts *config.SkaffoldOptions) (*runner.SkaffoldRunner, *latest.Sk
 		return nil, nil, errors.Wrap(err, "getting default repo")
 	}
 
-	if err = applyDefaultRepoSubstitution(config, defaultRepo); err != nil {
-		return nil, nil, errors.Wrap(err, "substituting default repos")
-	}
+	applyDefaultRepoSubstitution(config, defaultRepo)
 
 	runner, err := runner.NewForConfig(opts, config)
 	if err != nil {
@@ -69,16 +67,15 @@ func newRunner(opts *config.SkaffoldOptions) (*runner.SkaffoldRunner, *latest.Sk
 	return runner, config, nil
 }
 
-func applyDefaultRepoSubstitution(config *latest.SkaffoldPipeline, defaultRepo string) error {
+func applyDefaultRepoSubstitution(config *latest.SkaffoldPipeline, defaultRepo string) {
 	if defaultRepo == "" {
 		// noop
-		return nil
+		return
 	}
 	for _, artifact := range config.Build.Artifacts {
 		artifact.ImageName = util.SubstituteDefaultRepoIntoImage(defaultRepo, artifact.ImageName)
 	}
 	for _, testCase := range config.Test {
 		testCase.ImageName = util.SubstituteDefaultRepoIntoImage(defaultRepo, testCase.ImageName)
 	}
-	return nil
 }

hack/linter.sh

@@ -20,7 +20,7 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 if ! [ -x "$(command -v golangci-lint)" ]; then
 	echo "Installing GolangCI-Lint"
-	${DIR}/install_golint.sh -b $GOPATH/bin v1.12.5
+	${DIR}/install_golint.sh -b $GOPATH/bin v1.15.0
 fi
 
 golangci-lint run \
@@ -32,6 +32,7 @@ golangci-lint run \
 	-E interfacer \
 	-E maligned \
 	-E misspell \
+	-E stylecheck \
 	-E unconvert \
 	-E unparam \
 	-D errcheck \

pkg/skaffold/deploy/kubectl/labels.go

@@ -46,7 +46,7 @@ func newLabelsSetter(labels map[string]string) *labelsSetter {
 }
 
 func (r *labelsSetter) Matches(key string) bool {
-	return "metadata" == key
+	return key == "metadata"
 }
 
 func (r *labelsSetter) NewValue(old interface{}) (bool, interface{}) {