Merge pull request #2668 from corneliusweig/w/default-config-name

init: Add default config name

Author: tejal29

pkg/skaffold/initializer/init.go

@@ -26,9 +26,15 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"regexp"
 	"sort"
 	"strings"
 
+	"github.com/pkg/errors"
+	"github.com/sirupsen/logrus"
+	"gopkg.in/AlecAivazis/survey.v1"
+	"gopkg.in/yaml.v2"
+
 	"github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/tips"
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/config"
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/docker"
@@ -38,10 +44,6 @@ import (
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/latest"
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/util"
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/warnings"
-	"github.com/pkg/errors"
-	"github.com/sirupsen/logrus"
-	survey "gopkg.in/AlecAivazis/survey.v1"
-	yaml "gopkg.in/yaml.v2"
 )
 
 // For testing
@@ -391,9 +393,15 @@ func generateSkaffoldConfig(k Initializer, buildConfigPairs []builderImagePair)
 	// if the user doesn't have any k8s yamls, generate one for each dockerfile
 	logrus.Info("generating skaffold config")
 
+	name, err := suggestConfigName()
+	if err != nil {
+		warnings.Printf("Couldn't generate default config name: %s", err.Error())
+	}
+
 	cfg := &latest.SkaffoldConfig{
 		APIVersion: latest.Version,
 		Kind:       "Config",
+		Metadata:   latest.Metadata{Name: name},
 	}
 	if err := defaults.Set(cfg); err != nil {
 		return nil, errors.Wrap(err, "generating default pipeline")
@@ -410,6 +418,33 @@ func generateSkaffoldConfig(k Initializer, buildConfigPairs []builderImagePair)
 	return pipelineStr, nil
 }
 
+func suggestConfigName() (string, error) {
+	cwd, err := os.Getwd()
+	if err != nil {
+		return "", err
+	}
+
+	base := filepath.Base(cwd)
+
+	// give up for edge cases
+	if base == "." || base == string(filepath.Separator) {
+		return "", nil
+	}
+
+	return canonicalizeName(base), nil
+}
+
+// canonicalizeName converts a given string to a valid k8s name string.
+// See https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names for details
+func canonicalizeName(name string) string {
+	forbidden := regexp.MustCompile(`[^-.a-z]+`)
+	canonicalized := forbidden.ReplaceAllString(strings.ToLower(name), "-")
+	if len(canonicalized) <= 253 {
+		return canonicalized
+	}
+	return canonicalized[:253]
+}
+
 func printAnalyzeJSONNoJib(out io.Writer, skipBuild bool, pairs []builderImagePair, unresolvedBuilders []InitBuilder, unresolvedImages []string) error {
 	if !skipBuild && len(unresolvedBuilders) == 0 {
 		return errors.New("one or more valid Dockerfiles must be present to build images with skaffold; please provide at least one Dockerfile and try again, or run `skaffold init --skip-build`")

pkg/skaffold/initializer/init_test.go

@@ -498,3 +498,44 @@ func TestProcessCliArtifacts(t *testing.T) {
 		})
 	}
 }
+
+func Test_canonicalizeName(t *testing.T) {
+	const length253 = "aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa-aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa-aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaaaaaaaa.aaa"
+	tests := []struct {
+		in, out string
+	}{
+		{
+			in:  "abc def",
+			out: "abc-def",
+		},
+		{
+			in:  "abc    def",
+			out: "abc-def",
+		},
+		{
+			in:  "abc...def",
+			out: "abc...def",
+		},
+		{
+			in:  "abc---def",
+			out: "abc---def",
+		},
+		{
+			in:  "aBc DeF",
+			out: "abc-def",
+		},
+		{
+			in:  length253 + "XXXXXXX",
+			out: length253,
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.in, func(t *testing.T) {
+			actual := canonicalizeName(test.in)
+			if actual != test.out {
+				t.Errorf("%s: expected %s, found %s", test.in, test.out, actual)
+			}
+		})
+	}
+}