Support ~ in secret path for Kaniko

Signed-off-by: David Gageot <[email protected]>

Author: dgageot

examples/kaniko/skaffold.yaml

@@ -5,7 +5,7 @@ build:
   - imageName: gcr.io/k8s-skaffold/skaffold-example
   kaniko:
     gcsBucket: k8s-skaffold
-    pullSecret: /a/secret/path/kaniko.json
+    pullSecret: ~/secrets/kaniko/kaniko.json
 deploy:
   kubectl:
     manifests:

pkg/skaffold/schema/v1alpha2/config.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/constants"
+	homedir "github.com/mitchellh/go-homedir"
 
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
@@ -206,6 +207,19 @@ func setDefaultWorkspaces(cfg *SkaffoldConfig) {
 	}
 }
 
+func expandKanikoSecretPath(cfg *SkaffoldConfig) {
+	if cfg.Build.KanikoBuild == nil || cfg.Build.KanikoBuild.PullSecret == "" {
+		return
+	}
+
+	absPath, err := homedir.Expand(cfg.Build.KanikoBuild.PullSecret)
+	if err != nil {
+		logrus.Errorln("unable to expand pullSecret", cfg.Build.KanikoBuild.PullSecret)
+	} else {
+		cfg.Build.KanikoBuild.PullSecret = absPath
+	}
+}
+
 // ApplyProfiles returns configuration modified by the application
 // of a list of profiles.
 func (c *SkaffoldConfig) ApplyProfiles(profiles []string) error {
@@ -258,6 +272,7 @@ func (config *SkaffoldConfig) Parse(contents []byte, useDefaults bool, mode bool
 		setDefaultTagger(config, mode)
 		setDefaultDockerfiles(config)
 		setDefaultWorkspaces(config)
+		expandKanikoSecretPath(config)
 	}
 	return nil
 }