Merge pull request #579 from jonjohnsonjr/fix-scopes

dgageot · web-flow · commit 4b0219f3c191 · 2018-05-23T12:22:45.000+02:00
Fix push scopes in docker.AddTag
diff --git a/pkg/skaffold/docker/image.go b/pkg/skaffold/docker/image.go
@@ -123,7 +123,7 @@ func AddTag(src, target string) error {
 }
 
 func addTag(ref name.Reference, targetRef name.Reference, auth authn.Authenticator, t http.RoundTripper) error {
-	tr, err := transport.New(ref.Context().Registry, auth, t, []string{transport.PushScope})
+	tr, err := transport.New(ref.Context().Registry, auth, t, []string{targetRef.Scope(transport.PushScope)})
 	if err != nil {
 		return err
 	}

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ func AddTag(src, target string) error {`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`func addTag(ref name.Reference, targetRef name.Reference, auth authn.Authenticator, t http.RoundTripper) error {`
`126`		`- tr, err := transport.New(ref.Context().Registry, auth, t, []string{transport.PushScope})`
	`126`	`+ tr, err := transport.New(ref.Context().Registry, auth, t, []string{targetRef.Scope(transport.PushScope)})`
`127`	`127`	`if err != nil {`
`128`	`128`	`return err`
`129`	`129`	`}`