Skip to content

Commit 5456f1c

Browse files
author
Priya Wadhwa
committed
Address code review comments
1 parent 1c4780f commit 5456f1c

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

pkg/skaffold/deploy/kubectl/version.go

+5-6
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,11 @@ package kubectl
1919
import (
2020
"context"
2121
"encoding/json"
22-
"fmt"
23-
"os/exec"
24-
"strconv"
25-
2622
"github.com/GoogleContainerTools/skaffold/pkg/skaffold/util"
23+
"github.com/pkg/errors"
2724
"github.com/sirupsen/logrus"
25+
"os/exec"
26+
"strconv"
2827
)
2928

3029
const unknown = "unknown"
@@ -52,10 +51,10 @@ func (v ClientVersion) String() string {
5251
func (c *CLI) CheckVersion() error {
5352
m, err := strconv.Atoi(c.Version().Minor)
5453
if err != nil {
55-
return fmt.Errorf("couldn't get kubectl minor version: %v", err)
54+
return errors.Wrap(err, "couldn't get kubectl minor version")
5655
}
5756
if m < 12 {
58-
return fmt.Errorf("kubectl version 1.12.0 or greater is recommended for use with skaffold")
57+
return errors.New("kubectl version 1.12.0 or greater is recommended for use with skaffold")
5958
}
6059
return nil
6160
}

0 commit comments

Comments
 (0)