Skip to content

Commit 583502c

Browse files
committed
Add a few TODOs
Signed-off-by: David Gageot <[email protected]>
1 parent aeac032 commit 583502c

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

pkg/skaffold/build/buildpacks/dependencies.go

+1
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,6 @@ import (
2525

2626
// GetDependencies returns dependencies listed for a buildpack artifact
2727
func GetDependencies(ctx context.Context, workspace string, a *latest.BuildpackArtifact) ([]string, error) {
28+
// TODO(dgageot): Support project.toml include/exclude.
2829
return list.Files(workspace, a.Dependencies.Paths, a.Dependencies.Ignore)
2930
}

pkg/skaffold/build/buildpacks/lifecycle.go

+2
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@ func (b *Builder) build(ctx context.Context, out io.Writer, a *latest.Artifact,
107107
Env: env,
108108
Image: latest,
109109
NoPull: alreadyPulled,
110+
// TODO(dgageot): Support project.toml include/exclude.
111+
// FileFilter: func(string) bool { return true },
110112
}); err != nil {
111113
return "", err
112114
}

0 commit comments

Comments
 (0)