Skip to content

Commit 586da02

Browse files
authored
Merge pull request #3539 from dgageot/fix-schema-versions
Fix schema versions in a few samples
2 parents ae6f5ce + 0f7ae96 commit 586da02

File tree

7 files changed

+13
-7
lines changed

7 files changed

+13
-7
lines changed

examples/buildpacks-node/skaffold.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
apiVersion: skaffold/v2alpha1
1+
apiVersion: skaffold/v2alpha2
22
kind: Config
33
build:
44
artifacts:

examples/kustomize/skaffold-kustomize-args.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
apiVersion: skaffold/v2alpha1
1+
apiVersion: skaffold/v2alpha2
22
kind: Config
33
deploy:
44
kustomize:

examples/ruby/skaffold.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
apiVersion: skaffold/v2alpha1
1+
apiVersion: skaffold/v2alpha2
22
kind: Config
33
build:
44
artifacts:

hack/check-samples.sh

+7-1
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,12 @@ fi
3434
# /examples should use the latest released version
3535
LATEST_RELEASED="skaffold/$(go run ./hack/versions/cmd/latest_released/version.go)"
3636

37+
EXIT_CODE=0
38+
3739
for EXAMPLE in $(find examples -name skaffold*.yaml); do
3840
if [ "1" != "$(grep -c "apiVersion: ${LATEST_RELEASED}" "${EXAMPLE}")" ]; then
3941
echo "skaffold version in ${EXAMPLE} should be ${LATEST_RELEASED}"
42+
EXIT_CODE=1
4043
fi
4144
done
4245

@@ -46,5 +49,8 @@ LATEST="skaffold/$(go run ./hack/versions/cmd/latest/version.go)"
4649
for EXAMPLE in $(find integration/examples -name skaffold*.yaml); do
4750
if [ "1" != "$(grep -c "apiVersion: ${LATEST}" "${EXAMPLE}")" ]; then
4851
echo "skaffold version in ${EXAMPLE} should be ${LATEST}"
52+
EXIT_CODE=1
4953
fi
50-
done
54+
done
55+
56+
exit ${EXIT_CODE}

integration/examples/buildpacks-node/skaffold.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
apiVersion: skaffold/v2alpha1
1+
apiVersion: skaffold/v2alpha3
22
kind: Config
33
build:
44
artifacts:

integration/examples/kustomize/skaffold-kustomize-args.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
apiVersion: skaffold/v2alpha1
1+
apiVersion: skaffold/v2alpha3
22
kind: Config
33
deploy:
44
kustomize:

integration/examples/ruby/skaffold.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
apiVersion: skaffold/v2alpha1
1+
apiVersion: skaffold/v2alpha3
22
kind: Config
33
build:
44
artifacts:

0 commit comments

Comments
 (0)