Change SyncMap supported types check style

loosebazooka · loosebazooka · commit 67dc16418e93 · 2019-12-02T18:48:03.000-05:00
Allow for future extension with more supported builders like
jib, which is expected to produce a syncMap
diff --git a/pkg/skaffold/build/local/local.go b/pkg/skaffold/build/local/local.go
@@ -118,9 +118,9 @@ func (b *Builder) getImageIDForTag(ctx context.Context, tag string) (string, err
 }
 
 func (b *Builder) SyncMap(ctx context.Context, a *latest.Artifact) (map[string][]string, error) {
-	if a.DockerArtifact == nil {
-		return nil, build.ErrSyncMapNotSupported{}
+	if a.DockerArtifact != nil {
+		return docker.SyncMap(ctx, a.Workspace, a.DockerArtifact.DockerfilePath, a.DockerArtifact.BuildArgs, b.insecureRegistries)
 	}
+	return nil, build.ErrSyncMapNotSupported{}
 
-	return docker.SyncMap(ctx, a.Workspace, a.DockerArtifact.DockerfilePath, a.DockerArtifact.BuildArgs, b.insecureRegistries)
 }

Original file line number	Diff line number	Diff line change
`@@ -118,9 +118,9 @@ func (b *Builder) getImageIDForTag(ctx context.Context, tag string) (string, err`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`func (b Builder) SyncMap(ctx context.Context, a latest.Artifact) (map[string][]string, error) {`
`121`		`- if a.DockerArtifact == nil {`
`122`		`- return nil, build.ErrSyncMapNotSupported{}`
	`121`	`+ if a.DockerArtifact != nil {`
	`122`	`+ return docker.SyncMap(ctx, a.Workspace, a.DockerArtifact.DockerfilePath, a.DockerArtifact.BuildArgs, b.insecureRegistries)`
`123`	`123`	`}`
	`124`	`+ return nil, build.ErrSyncMapNotSupported{}`
`124`	`125`
`125`		`- return docker.SyncMap(ctx, a.Workspace, a.DockerArtifact.DockerfilePath, a.DockerArtifact.BuildArgs, b.insecureRegistries)`
`126`	`126`	`}`