code review rename comments

Author: tejal29

pkg/skaffold/build/cache/lookup.go

@@ -79,6 +79,7 @@ func (c *cache) lookupLocal(ctx context.Context, hash, tag string, entry ImageDe
 	// Check the imageID for the tag
 	idForTag, err := c.client.ImageID(ctx, tag)
 	if err != nil {
+		// Rely on actionable errors thrown from pkg/skaffold/docker.LocalDaemon api.
 		return failed{err: err}
 	}
 

pkg/skaffold/build/jib/build.go

@@ -44,6 +44,6 @@ func (b *Builder) Build(ctx context.Context, out io.Writer, artifact *latest.Art
 		return b.buildJibGradleToDocker(ctx, out, artifact.Workspace, artifact.JibArtifact, artifact.Dependencies, tag)
 
 	default:
-		return "", unknownPlugin(artifact.Workspace)
+		return "", unknownPluginType(artifact.Workspace)
 	}
 }

pkg/skaffold/build/jib/errors.go

@@ -25,7 +25,7 @@ import (
 	"github.com/GoogleContainerTools/skaffold/proto"
 )
 
-func unknownPlugin(ws string) error {
+func unknownPluginType(ws string) error {
 	return sErrors.NewErrorWithStatusCode(
 		proto.ActionableErr{
 			Message: fmt.Sprintf("Unknown Jib builder type for workspace %s", ws),
@@ -39,7 +39,7 @@ func unknownPlugin(ws string) error {
 		})
 }
 
-func unableToDeterminePlugin(ws string, err error) error {
+func unableToDeterminePluginType(ws string, err error) error {
 	return sErrors.NewError(err,
 		proto.ActionableErr{
 			Message: fmt.Sprintf("unable to determine Jib builder type for workspace %s due to %s", ws, err),

pkg/skaffold/build/jib/jib.go

@@ -103,15 +103,15 @@ func GetBuildDefinitions(workspace string, a *latest.JibArtifact) []string {
 func GetDependencies(ctx context.Context, workspace string, artifact *latest.JibArtifact) ([]string, error) {
 	t, err := DeterminePluginType(workspace, artifact)
 	if err != nil {
-		return nil, unableToDeterminePlugin(workspace, err)
+		return nil, unableToDeterminePluginType(workspace, err)
 	}
 	switch t {
 	case JibMaven:
 		return getDependenciesMaven(ctx, workspace, artifact)
 	case JibGradle:
 		return getDependenciesGradle(ctx, workspace, artifact)
 	default:
-		return nil, unknownPlugin(workspace)
+		return nil, unknownPluginType(workspace)
 	}
 }