chore: support artifactOverrides schema functionality from v2beta* in v3alpha*

Author: aaron-prindle

examples/templated-fields/charts/values.yaml

@@ -2,3 +2,4 @@
 # This is a YAML-formatted file.
 # Declare variables to be passed into your templates.
 replicaCount: 2
+image: skaffold-templated

examples/templated-fields/skaffold.yaml

@@ -16,8 +16,6 @@ deploy:
     releases:
     - name: skaffold-templated
       chartPath: charts
-      artifactOverrides:
-        image: skaffold-templated
       setValueTemplates:
         imageRepo: "{{.IMAGE_REPO}}"
         imageTag: "{{.IMAGE_TAG}}"

pkg/skaffold/schema/v2beta29/upgrade.go

@@ -18,6 +18,7 @@ package v2beta29
 
 import (
 	"encoding/json"
+	"fmt"
 
 	"github.com/pkg/errors"
 
@@ -87,6 +88,31 @@ func upgradeOnePipeline(oldPipeline, newPipeline interface{}) error {
 		newPL.Render.Helm.Releases = newHelm.Releases
 		newPL.Render.Helm.Flags = newHelm.Flags
 
+		// Copy over removed artifactOverrides & imageStrategy field as identical setValues fields
+		for i := 0; i < len(newPL.Render.Helm.Releases); i++ {
+			// need to append, not override
+			svs := map[string]string(oldPL.Deploy.HelmDeploy.Releases[i].SetValues)
+			aos := map[string]string(oldPL.Deploy.HelmDeploy.Releases[i].ArtifactOverrides)
+			if aos != nil && svs == nil {
+				svs = map[string]string{}
+			}
+			// TODO(aaron-prindle) - upgrade currently only supports FQN image strategy, need to add: helm & helm+explicitRegistry
+			if oldPL.Deploy.HelmDeploy.Releases[i].ImageStrategy.HelmConventionConfig != nil {
+				// is 'helm'
+				if oldPL.Deploy.HelmDeploy.Releases[i].ImageStrategy.HelmConventionConfig.ExplicitRegistry {
+					// is 'helm' + explicitRegistry
+					return fmt.Errorf("skaffold v2.0.0 binary w/ v3alpha1 schema does not support deploy.helm.imageStrategy=helm currently")
+				}
+				return fmt.Errorf("skaffold v2.0.0 binary w/ v3alpha1 schema does not support imageStrategy.helm.imageStrategy=helm currently")
+			} else {
+				// is 'fqn'
+				for k, v := range aos {
+					svs[k] = v
+				}
+			}
+			newPL.Render.Helm.Releases[i].SetValues = svs
+		}
+
 		// Copy over lifecyle hooks for helm deployer
 		newPL.Deploy.LegacyHelmDeploy = &next.LegacyHelmDeploy{}
 		newPL.Deploy.LegacyHelmDeploy.LifecycleHooks = newHelm.LifecycleHooks