Skip to content

Commit 927e28d

Browse files
author
priyawadhwa
authored
Merge pull request #1504 from dgageot/remove-copy-delete-logs
Don’t log if nothing is copied or deleted
2 parents dec8491 + 7778083 commit 927e28d

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

pkg/skaffold/sync/kubectl/kubectl.go

+10-6
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,20 @@ type Syncer struct{}
3333
var syncedDirs = map[string]struct{}{}
3434

3535
func (k *Syncer) Sync(ctx context.Context, s *sync.Item) error {
36-
logrus.Infoln("Copying files:", s.Copy, "to", s.Image)
36+
if len(s.Copy) > 0 {
37+
logrus.Infoln("Copying files:", s.Copy, "to", s.Image)
3738

38-
if err := sync.Perform(ctx, s.Image, s.Copy, copyFileFn); err != nil {
39-
return errors.Wrap(err, "copying files")
39+
if err := sync.Perform(ctx, s.Image, s.Copy, copyFileFn); err != nil {
40+
return errors.Wrap(err, "copying files")
41+
}
4042
}
4143

42-
logrus.Infoln("Deleting files:", s.Delete, "from", s.Image)
44+
if len(s.Delete) > 0 {
45+
logrus.Infoln("Deleting files:", s.Delete, "from", s.Image)
4346

44-
if err := sync.Perform(ctx, s.Image, s.Delete, deleteFileFn); err != nil {
45-
return errors.Wrap(err, "deleting files")
47+
if err := sync.Perform(ctx, s.Image, s.Delete, deleteFileFn); err != nil {
48+
return errors.Wrap(err, "deleting files")
49+
}
4650
}
4751

4852
return nil

0 commit comments

Comments
 (0)