This flag is redundant with KustomizeDeployer.KustomizeDeploy.BuildArgs (#4559)

dgageot · web-flow · commit a9d53d189e34 · 2020-07-24T16:45:37.000+02:00
Signed-off-by: David Gageot &lt;david@gageot.net&gt;
diff --git a/pkg/skaffold/deploy/kustomize.go b/pkg/skaffold/deploy/kustomize.go
@@ -97,7 +97,6 @@ type KustomizeDeployer struct {
 	kubectl            deploy.CLI
 	insecureRegistries map[string]bool
 	labels             map[string]string
-	BuildArgs          []string
 	globalConfig       string
 }
 
@@ -110,7 +109,6 @@ func NewKustomizeDeployer(runCtx *runcontext.RunContext, labels map[string]strin
 			ForceDeploy: runCtx.Opts.Force,
 		},
 		insecureRegistries: runCtx.InsecureRegistries,
-		BuildArgs:          runCtx.Cfg.Deploy.KustomizeDeploy.BuildArgs,
 		globalConfig:       runCtx.Opts.GlobalConfig,
 		labels:             labels,
 	}

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,6 @@ type KustomizeDeployer struct {`
`97`	`97`	`kubectl deploy.CLI`
`98`	`98`	`insecureRegistries map[string]bool`
`99`	`99`	`labels map[string]string`
`100`		`- BuildArgs []string`
`101`	`100`	`globalConfig string`
`102`	`101`	`}`
`103`	`102`
`@@ -110,7 +109,6 @@ func NewKustomizeDeployer(runCtx *runcontext.RunContext, labels map[string]strin`
`110`	`109`	`ForceDeploy: runCtx.Opts.Force,`
`111`	`110`	`},`
`112`	`111`	`insecureRegistries: runCtx.InsecureRegistries,`
`113`		`- BuildArgs: runCtx.Cfg.Deploy.KustomizeDeploy.BuildArgs,`
`114`	`112`	`globalConfig: runCtx.Opts.GlobalConfig,`
`115`	`113`	`labels: labels,`
`116`	`114`	`}`