Skip to content

Commit a9fac45

Browse files
committed
Validate late to catch errors from profile application
1 parent e2eab9d commit a9fac45

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

cmd/skaffold/app/cmd/runner.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@ func newRunner(opts *config.SkaffoldOptions) (*runner.SkaffoldRunner, *latest.Sk
4444

4545
config := parsed.(*latest.SkaffoldPipeline)
4646

47-
if err := validation.ValidateSchema(config); err != nil {
48-
return nil, nil, errors.Wrap(err, "invalid skaffold config")
49-
}
50-
5147
if err = schema.ApplyProfiles(config, opts); err != nil {
5248
return nil, nil, errors.Wrap(err, "applying profiles")
5349
}
@@ -56,6 +52,10 @@ func newRunner(opts *config.SkaffoldOptions) (*runner.SkaffoldRunner, *latest.Sk
5652
return nil, nil, errors.Wrap(err, "setting default values")
5753
}
5854

55+
if err := validation.ValidateSchema(config); err != nil {
56+
return nil, nil, errors.Wrap(err, "invalid skaffold config")
57+
}
58+
5959
defaultRepo, err := configutil.GetDefaultRepo(opts.DefaultRepo)
6060
if err != nil {
6161
return nil, nil, errors.Wrap(err, "getting default repo")

0 commit comments

Comments
 (0)