Show message "Press ctrl c to exit" on forward manager start (#4113)

gsquared94 · web-flow · commit c261d1c07e7f · 2020-05-10T10:16:25.000+02:00
* Show message "Press ctrl c to exit" on forward manager start

* Move message to only for port-fordwarding.

* Don't print if port forwarding errors out

* Change text
diff --git a/pkg/skaffold/runner/build_deploy.go b/pkg/skaffold/runner/build_deploy.go
@@ -117,6 +117,8 @@ func (r *SkaffoldRunner) DeployAndLog(ctx context.Context, out io.Writer, artifa
 	if r.runCtx.Opts.PortForward.Enabled {
 		if err := r.forwarderManager.Start(ctx); err != nil {
 			logrus.Warnln("Error starting port forwarding:", err)
+		} else {
+			color.Yellow.Fprintln(out, "Press Ctrl+C to exit")
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,8 @@ func (r *SkaffoldRunner) DeployAndLog(ctx context.Context, out io.Writer, artifa`
`117`	`117`	`if r.runCtx.Opts.PortForward.Enabled {`
`118`	`118`	`if err := r.forwarderManager.Start(ctx); err != nil {`
`119`	`119`	`logrus.Warnln("Error starting port forwarding:", err)`
	`120`	`+ } else {`
	`121`	`+ color.Yellow.Fprintln(out, "Press Ctrl+C to exit")`
`120`	`122`	`}`
`121`	`123`	`}`
`122`	`124`