Skip to content

Commit da1fb59

Browse files
authored
Merge pull request #2890 from tejal29/remove_skaffold_file_check
Removing testing version dependent skaffold config test in examples
2 parents a892d79 + 75030a7 commit da1fb59

File tree

2 files changed

+5
-23
lines changed

2 files changed

+5
-23
lines changed

integration/examples/generate-pipeline/expectedSkaffold.yaml

-22
This file was deleted.

integration/generate_pipeline_test.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ func TestGeneratePipeline(t *testing.T) {
4444
input []byte
4545
args []string
4646
configFiles []string
47+
skipCheck bool
4748
}{
4849
{
4950
description: "no profiles",
@@ -70,6 +71,7 @@ func TestGeneratePipeline(t *testing.T) {
7071
description: "user example",
7172
dir: "examples/generate-pipeline",
7273
input: []byte("y\n"),
74+
skipCheck: true,
7375
},
7476
}
7577

@@ -95,7 +97,9 @@ func TestGeneratePipeline(t *testing.T) {
9597
}
9698
skaffold.GeneratePipeline(args...).WithStdin(test.input).WithEnv(skaffoldEnv).InDir(test.dir).RunOrFail(t)
9799

98-
checkFileContents(t, test.dir+"/expectedSkaffold.yaml", test.dir+"/skaffold.yaml")
100+
if !test.skipCheck {
101+
checkFileContents(t, test.dir+"/expectedSkaffold.yaml", test.dir+"/skaffold.yaml")
102+
}
99103
checkFileContents(t, test.dir+"/expectedPipeline.yaml", test.dir+"/pipeline.yaml")
100104
})
101105
}

0 commit comments

Comments
 (0)