Skip to content

init: Add default skaffold-config name? #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corneliusweig opened this issue Jul 26, 2019 · 1 comment · Fixed by #2668
Closed

init: Add default skaffold-config name? #2556

corneliusweig opened this issue Jul 26, 2019 · 1 comment · Fixed by #2668

Comments

@corneliusweig
Copy link
Contributor

Since #2437 the skaffold.yaml can have a metadata.name field. With upcoming changes for configurable kubecontext, this name-field needs to be set when creating a project-kubeContext relation (see #2384 (comment) for details).

So far, skaffold init is completely ignorant about this field, but I think we can make our users' lives easier if init takes care of the name field. There are two basic options:

  1. Prompt the user for a name (with a suggestion). The downside here is that skaffold init will obviously require more user interaction.
  2. Provide a sane default without prompting the user.

Both options need a sane default. A reasonable default value could be to use the directory basename of the current working dir.

So what do you think? Should skaffold init do that, and what should be the default?

@nkubala
Copy link
Contributor

nkubala commented Aug 8, 2019

yeah I think we should try and have as little user input in skaffold init as possible. i'm fine with putting a default in, your suggestion of the current directory basename seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants