Skip to content

skaffold deploy (and even skaffold fix) validates existence of "build->artifacts->context" #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucasmaj opened this issue Aug 3, 2020 · 4 comments · Fixed by #4657
Closed
Assignees
Labels
kind/bug Something isn't working kind/usability priority/p2 May take a couple of releases

Comments

@lucasmaj
Copy link

lucasmaj commented Aug 3, 2020

Expected behavior

Existence of "build->artifacts->context" path has no bearing on "deploy" (nor "fix", nor any other pipeline that does not need it, so "build" only???). When using "deploy" separately from "build", context path (which is used for "build") is not guaranteed to exist during "deploy". Does "deploy" need context anyway?

Actual behavior

Error thrown stating that context does not exist.

invalid skaffold config: image "some.azurecr.io/myproject" context "./publish/myproject/" does not exist

Information

  • Skaffold version: 1.13.0
  • Operating system: Windows and Linux, others unsure
  • Contents of skaffold.yaml:
apiVersion: skaffold/v1
kind: Config
build:
  artifacts:
  - image: some.azurecr.io/myproject
    context: "./publish/myproject/"
    docker:
      dockerfile: "./path/to/some/Dockerfile"
deploy:
  kubectl:
    manifests:
    - myproject/deployment.yaml

Steps to reproduce the behavior

  1. skaffold build (or skaffold fix) above skaffold.yaml
  2. To see a working version just comment out "context" or provide existing path.
@gsquared94 gsquared94 added the triage/discuss Items for discussion label Aug 5, 2020
@gsquared94
Copy link
Contributor

Your expected behavior definitely sounds reasonable. I'll discuss in our weekly triage what, if anything, necessitated the existence of a build context always.

@lucasmaj
Copy link
Author

lucasmaj commented Aug 5, 2020

Also would like to point out that this behavior was introduced in 1.13.0. Our workaround right now is to use v1.12.1.

@gsquared94 gsquared94 added kind/bug Something isn't working priority/p2 May take a couple of releases labels Aug 5, 2020
@briandealwis
Copy link
Member

This was introduced by #4492.

@lucasmaj
Copy link
Author

Confirming it is fixed in v1.13.2. Thank you!

@briandealwis briandealwis removed the triage/discuss Items for discussion label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/usability priority/p2 May take a couple of releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants