-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Debug doesn't work with Helm on Windows #4862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are you using bash on Windows? As part of the support, we recursively invoke Skaffold to apply some filters to the Helm-rendered output. We write out the list of the built artifacts to a file that is passed into this recursed |
Hey @briandealwis! I tried with both cmd.exe and git bash and it produced the same results 😔 The path to the built artifacts seems wrong, I tried to find out where it is generated in the code, without success. Until then any ideas are welcome 👍🙂 |
@aurelien-baumann-lacapitale the relevant code is here. Would you mind running |
Here it is.
|
Also running these commands in cmd.exe:
outputs:
|
So there should be a The problem is that the backslashes in the Windows path name passed to skaffold/cmd/skaffold/app/skaffold.go Line 39 in da65fa5
but I'm joining them using shell.Join() :skaffold/pkg/skaffold/deploy/helm/helm.go Line 399 in da65fa5
🤦 |
Oh I get it... It doesn't sound like good news as github.com/kballard/go-shellquote seems to be used in a pretty hot place of the codebase 🤭 Is there something I can to do to help? |
Ok you code faster than I type comments 🤠 |
Expected behavior
The following command :
C:\ProgramData\chocolatey\lib\skaffold\tools\skaffold.exe debug --filename skaffold.yaml --rpc-port 50051 --port-forward=true --enable-rpc=true
should work on Windows 10 with helm deployer.Actual behavior
The command produces the following error:
Information
Steps to reproduce the behavior
The error only occurs on Windows and only when using Helm deployer.
Maybe it has something to do with the quite odd path
C:UsersMYUSER~1AppDataLocalTempbuilds132295643.yaml
.As debug support for Helm was recently merged, maybe @nkubala would have an idea about it? 🙂
The text was updated successfully, but these errors were encountered: