Skip to content

New files are not synced to running container. #5110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drover25 opened this issue Dec 4, 2020 · 8 comments · Fixed by #5121
Closed

New files are not synced to running container. #5110

drover25 opened this issue Dec 4, 2020 · 8 comments · Fixed by #5121
Assignees
Labels
area/sync kind/bug Something isn't working kind/regression priority/p0 Highest priority. We are actively looking at delivering it.
Milestone

Comments

@drover25
Copy link

drover25 commented Dec 4, 2020

When a new file which matches the glob in sync.manual is created, it is not synced to the running container. Changes to existing files are synced as expected.

This behaviour first appears in 1.17

Expected behavior

New files which match sync.manual are synced to the running container.

Actual behavior

The new file is not picked up

Information

  • Skaffold version: >=1.17
  • Operating system: MacOS
  • Contents of skaffold.yaml:
apiVersion: skaffold/v2alpha4
kind: Config
metadata:
  name: rally-app
build:
  local:
    useDockerCLI: true
    useBuildkit: true
profiles:
  - name: dev
    build:
      artifacts:
        - image: my-image
          sync:
            manual:
              - src: frontend/src/**/*
                dest: .
                strip: frontend/
              - src: frontend/public/**/*
                dest: .
                strip: frontend/
          docker:
            dockerfile: frontend/Dockerfile
    deploy:
      kustomize:
        paths:
          - kubernetes/environments/dev
      kubeContext: docker-desktop
@drover25
Copy link
Author

drover25 commented Dec 4, 2020

Suspect PR: #5016

@gsquared94
Copy link
Contributor

Another suspect: #4896

@gsquared94 gsquared94 added area/sync kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it. labels Dec 4, 2020
@martinseanhunt
Copy link

I'm experiencing this too allthough strangely only on one artifact of 5 I have running in a build

@martinseanhunt
Copy link

I just realised I was running 1.17.0 and upgrading to 1.17.1 seems to have solved this for me.

@InsideGH
Copy link

InsideGH commented Dec 7, 2020

I'm experience this issue with 1.17.1 (running pop/ubuntu20.10 & minikube). However, going back to 1.16.0 I don't have any sync issues with newly created files.

@tejal29 tejal29 self-assigned this Dec 7, 2020
@tejal29
Copy link
Contributor

tejal29 commented Dec 7, 2020

@martinseanhunt 1.17.1 should also have the same issue.
@InsideGH you are right, 1.16.0 will address this issue.

@tejal29
Copy link
Contributor

tejal29 commented Dec 9, 2020

Fixed it in https://github.com/GoogleContainerTools/skaffold/releases/tag/v1.17.2

@drover25
Copy link
Author

drover25 commented Dec 9, 2020

Thanks so much for the quick turnaround on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sync kind/bug Something isn't working kind/regression priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants