Skip to content

Debug docs should warn about re-entrancy with probes #5425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
briandealwis opened this issue Feb 20, 2021 · 0 comments · Fixed by #5474
Closed

Debug docs should warn about re-entrancy with probes #5425

briandealwis opened this issue Feb 20, 2021 · 0 comments · Fixed by #5474
Labels

Comments

@briandealwis
Copy link
Member

briandealwis commented Feb 20, 2021

We encountered a situation where a breakpoint was placed on the calling path of a user was stopped in a breakpoint. This pod had a liveness probe that called back into the app. Because the server was blocked due to the debug session in progress, and liveness probes have a timeout of 1 second, the probe was deemed to have failed and k8s restarted the container.

  containers:
  - name: example
    image: example-image
    ports:
    - containerPort: 8080
    # connect to the app port
    livenessProbe:
      httpGet:
        path: /
        port: 8080
      initialDelaySeconds: 2
      periodSeconds: 10

it makes sense that a developer might want to debug a liveness or readiness or startup probe. Debug could rewrite such probes to set/increase the timeout period of 5 minutes (ideally configurable in some way).

cc: @VeerMuchandi

@briandealwis briandealwis changed the title Debug should increase timeouts for probes Debug docs should warn about re-entrancy with probes Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant