Skip to content

Multi-Skaffold project warns about helm problem not replacing image names #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arash16 opened this issue Feb 25, 2021 · 4 comments
Closed
Assignees
Labels
area/modules kind/bug Something isn't working kind/usability priority/p2 May take a couple of releases

Comments

@arash16
Copy link

arash16 commented Feb 25, 2021

I have a root skaffold that requires multiple other skaffold.yaml files. If I comment out all requires except one of them, everything works fine. But when I requires multiple skaffold.yaml files, skaffold gives following warnings:

WARN[0266] image [xyz:635e1d16cc34642aa45bac89df9ed7366eb79d1e78aa4f237141aa5145d4918a] is not used. 
WARN[0266] image [xyz] is used instead. 
WARN[0266] See helm sample for how to replace image names with their actual tags: https://github.com/GoogleContainerTools/skaffold/blob/master/examples/helm-deployment/skaffold.yaml

Information

  • Skaffold version: 1.20.0
  • Operating system: Linux Mint 19
  • Contents of skaffold.yaml:

skaffold.yaml

apiVersion: skaffold/v2beta12
kind: Config
metadata:
  name: root
requires:
- path: ./backend
- path: ./frontend

backend/skaffold.yaml

apiVersion: skaffold/v2beta12
kind: Config
metadata:
  name: backend
build:
  artifacts:
  - image: backend
    sync:
      infer:
      - "*/**/*.js"

deploy:
  helm:
    releases:
    - name: backend
      chartPath: ../infra/charts/microservice
      artifactOverrides:
        image: backend
      valuesFiles:
      - backend/service-values.yaml

profiles:
  - name: dev
    activation:
      - command: dev
    patches:
      - op: add
        path: /deploy/helm/releases/0/setValues
        value:
          ingress.tld: localhost
          env.NODE_ENV: development
          env.LOGLEVEL: debug

frontend/skaffold.yaml

apiVersion: skaffold/v2beta12
kind: Config
metadata:
  name: frontend
build:
  artifacts:
  - image: frontend
    sync:
      infer:
      - "*/**/*.js"

deploy:
  helm:
    releases:
    - name: frontend
      chartPath: ../infra/charts/microservice
      artifactOverrides:
        image: frontend
      valuesFiles:
      - frontend/service-values.yaml

profiles:
  - name: dev
    activation:
      - command: dev
    patches:
      - op: add
        path: /deploy/helm/releases/0/setValues
        value:
          ingress.tld: localhost
          env.NODE_ENV: development
          env.LOGLEVEL: debug
@tejal29 tejal29 added area/modules kind/bug Something isn't working kind/usability priority/p2 May take a couple of releases labels Feb 25, 2021
@gsquared94 gsquared94 added the needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug label Feb 26, 2021
@gsquared94 gsquared94 self-assigned this Feb 26, 2021
@gsquared94
Copy link
Contributor

able to repro

@gsquared94 gsquared94 added triage/discuss Items for discussion and removed needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug labels Feb 26, 2021
@tejal29 tejal29 removed the triage/discuss Items for discussion label Apr 5, 2021
@dhodun
Copy link

dhodun commented Apr 7, 2021

Am seeing similar behavior in our app. The rest of the required configs are using kustomize, so was a little strange to see helm errors on those images. Base on this seems the issue is related more to mulptiple configs (I didn't collapse the configs to test, though).

@artemkoru
Copy link
Contributor

I have the same problem with skaffold v1.21.0

@gsquared94
Copy link
Contributor

this should be fixed via #5468 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modules kind/bug Something isn't working kind/usability priority/p2 May take a couple of releases
Projects
None yet
Development

No branches or pull requests

5 participants