Skip to content

Enable namespace flag for non-helm deploys #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slamdev opened this issue Jul 23, 2018 · 2 comments
Closed

Enable namespace flag for non-helm deploys #849

slamdev opened this issue Jul 23, 2018 · 2 comments
Labels
area/deploy kind/feature-request

Comments

@slamdev
Copy link
Contributor

slamdev commented Jul 23, 2018

Expected behavior

Replace namespace value in deploying manifests when it is provided via command-line for kubectl deploys

Actual behavior

Works only for helm deploys

Information

It would be nice to extend existing namespace flag to work with both helm and kubectl deploys.
@dgageot
Copy link
Contributor

dgageot commented Jul 26, 2018

Hey @slamdev thanks for asking. I pushed support for this feature before I saw your issue! #852

@slamdev
Copy link
Contributor Author

slamdev commented Jul 27, 2018

@dgageot cool! thanks :)

@slamdev slamdev closed this as completed Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/deploy kind/feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgageot @slamdev