Fix e2e tests for WordPress 6.7 (#13848)

Author: swissspidy

packages/e2e-test-utils/src/trashAllPosts.js

@@ -41,10 +41,21 @@ async function trashAllPosts(postType = 'post') {
     // Select all posts.
     await page.waitForSelector('[id^=cb-select-all-]');
     await page.click('[id^=cb-select-all-]');
+
     // Select the "bulk actions" > "trash" option.
     await page.select('#bulk-action-selector-top', 'trash');
-    // Submit the form to send all draft/scheduled/published posts to the trash.
-    await Promise.all([page.waitForNavigation(), page.click('#doaction')]);
+
+    // Bail early if there were no items selected,
+    // e.g. if there were no posts or if they were all locked.
+    // See https://core.trac.wordpress.org/ticket/45006.
+    const hasSelectedCheckboxes = await page.evaluate(
+      () => document.querySelectorAll('input[name="post[]"]:checked').length > 0
+    );
+
+    if (hasSelectedCheckboxes) {
+      // Submit the form to send all draft/scheduled/published posts to the trash.
+      await Promise.all([page.waitForNavigation(), page.click('#doaction')]);
+    }
   }
 
   await setCurrentUser(currentUser.username, currentUser.password);

packages/e2e-tests/src/puppeteerEnvironment.js

@@ -39,24 +39,30 @@ class PuppeteerEnvironment extends JestPuppeteer.TestEnvironment {
   }
 
   async handleTestEvent(event, state) {
-    if (event.name === 'test_fn_failure') {
-      const testName = `${state.currentlyRunningTest.parent.name}  ${state.currentlyRunningTest.name}`;
-      const errors = state.currentlyRunningTest.errors;
-      const eventError = util.inspect(event);
+    if (event.name === 'test_fn_failure' || event.name === 'hook_failure') {
+      const testName =
+        event.name === 'test_fn_failure'
+          ? `${state.currentlyRunningTest.parent.name}  ${state.currentlyRunningTest.name}`
+          : 'before or after hook';
+
       let errorMessages = '';
-      errorMessages += `========= ${testName} ==========\n\n`;
-      errorMessages +=
-        'started:' +
-        new Date(event.test.startedAt).toLocaleString() +
-        ' ended:' +
-        new Date().toLocaleString();
-      errorMessages += '============end==========\n\n';
-      errors.forEach((error) => {
-        errorMessages += `${testName}:${error}\n\n`;
-      });
 
-      errorMessages += '=========================\n\n';
-      errorMessages += eventError;
+      if (event.test) {
+        const errors = state.currentlyRunningTest?.errors || [];
+        const eventError = util.inspect(event);
+        errorMessages += `========= ${testName} ==========\n\n`;
+        errorMessages +=
+          'started:' +
+          new Date(event.test.startedAt).toLocaleString() +
+          ' ended:' +
+          new Date().toLocaleString();
+        errorMessages += '============end==========\n\n';
+        errors.forEach((error) => {
+          errorMessages += `${testName}:${error}\n\n`;
+        });
+        errorMessages += '=========================\n\n';
+        errorMessages += eventError;
+      }
 
       await this.storeArtifacts(testName, errorMessages);
     }