Lint: fix errcheck for policy, body_test, proxy_test caddyserver#2541

Author: Inconnu08

caddyhttp/proxy/body_test.go

@@ -18,6 +18,7 @@ import (
 	"bytes"
 	"io"
 	"io/ioutil"
+	"log"
 	"net/http"
 	"net/http/httptest"
 	"testing"
@@ -47,12 +48,16 @@ func TestBodyRetry(t *testing.T) {
 	// simulate fail request
 	host := req.URL.Host
 	req.URL.Host = "example.com"
-	body.rewind()
+	if err := body.rewind(); err != nil {
+		log.Println("[ERROR] failed re-read bufferedBody: ", err)
+	}
 	_, _ = http.DefaultTransport.RoundTrip(req)
 
 	// retry request
 	req.URL.Host = host
-	body.rewind()
+	if err := body.rewind(); err != nil {
+		log.Println("[ERROR] failed re-read bufferedBody: ", err)
+	}
 	resp, err := http.DefaultTransport.RoundTrip(req)
 	if err != nil {
 		t.Fatal(err)
@@ -67,7 +72,9 @@ func TestBodyRetry(t *testing.T) {
 	}
 
 	// try one more time for body reuse
-	body.rewind()
+	if err := body.rewind(); err != nil {
+		log.Println("[ERROR] failed re-read bufferedBody: ", err)
+	}
 	resp, err = http.DefaultTransport.RoundTrip(req)
 	if err != nil {
 		t.Fatal(err)

caddyhttp/proxy/policy.go

@@ -16,6 +16,7 @@ package proxy
 
 import (
 	"hash/fnv"
+	"log"
 	"math"
 	"math/rand"
 	"net"
@@ -139,7 +140,9 @@ func hostByHashing(pool HostPool, s string) *UpstreamHost {
 // hash calculates a hash based on string s
 func hash(s string) uint32 {
 	h := fnv.New32a()
-	h.Write([]byte(s))
+	if _, err := h.Write([]byte(s)); err != nil {
+		log.Println("[ERROR] failed to write bytes: ", err)
+	}
 	return h.Sum32()
 }