Skip to content

Commit fe3f214

Browse files
committed
Lint: fix errcheck for responsefilter_test, fcgilient_test caddyserver#2541
1 parent 4d35a4c commit fe3f214

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

caddyhttp/fastcgi/fcgiclient_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,9 @@ func generateRandFile(size int) (p string, m string) {
202202
if _, err := fo.Write(buf); err != nil {
203203
log.Printf("[ERROR] failed to write buffer: %v\n", err)
204204
}
205-
h.Write(buf)
205+
if _, err := h.Write(buf); err != nil {
206+
log.Printf("[ERROR] failed to write buffer: %v\n", err)
207+
}
206208
}
207209
m = fmt.Sprintf("%x", h.Sum(nil))
208210
return

caddyhttp/gzip/responsefilter_test.go

+13-4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ package gzip
1717
import (
1818
"compress/gzip"
1919
"fmt"
20+
"log"
2021
"net/http"
2122
"net/http/httptest"
2223
"testing"
@@ -77,7 +78,9 @@ func TestResponseFilterWriter(t *testing.T) {
7778
for i, ts := range tests {
7879
server.Next = httpserver.HandlerFunc(func(w http.ResponseWriter, r *http.Request) (int, error) {
7980
w.Header().Set("Content-Length", fmt.Sprint(len(ts.body)))
80-
w.Write([]byte(ts.body))
81+
if _, err := w.Write([]byte(ts.body)); err != nil {
82+
log.Println("[ERROR] failed to write response: ", err)
83+
}
8184
return 200, nil
8285
})
8386

@@ -86,7 +89,9 @@ func TestResponseFilterWriter(t *testing.T) {
8689

8790
w := httptest.NewRecorder()
8891

89-
server.ServeHTTP(w, r)
92+
if _, err := server.ServeHTTP(w, r); err != nil {
93+
log.Println("[ERROR] unable to serve a gzipped response: ", err)
94+
}
9095

9196
resp := w.Body.String()
9297

@@ -109,15 +114,19 @@ func TestResponseGzippedOutput(t *testing.T) {
109114

110115
server.Next = httpserver.HandlerFunc(func(w http.ResponseWriter, r *http.Request) (int, error) {
111116
w.Header().Set("Content-Encoding", "gzip")
112-
w.Write([]byte("gzipped"))
117+
if _, err := w.Write([]byte("gzipped")); err != nil {
118+
log.Println("[ERROR] failed to write response: ", err)
119+
}
113120
return 200, nil
114121
})
115122

116123
r := urlRequest("/")
117124
r.Header.Set("Accept-Encoding", "gzip")
118125

119126
w := httptest.NewRecorder()
120-
server.ServeHTTP(w, r)
127+
if _, err := server.ServeHTTP(w, r); err != nil {
128+
log.Println("[ERROR] unable to serve a gzipped response: ", err)
129+
}
121130
resp := w.Body.String()
122131

123132
if resp != "gzipped" {

0 commit comments

Comments
 (0)