Skip to content

Commit 6153a13

Browse files
authored
fix(jans-auth-server): jansApp attribute only relevant for SG (#3782)
1 parent d71b3e2 commit 6153a13

File tree

6 files changed

+15
-8
lines changed

6 files changed

+15
-8
lines changed

docs/script-catalog/person_authentication/fido2-external-authenticator/Fido2ExternalAuthenticator.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@ def prepareForStep(self, configurationAttributes, requestParameters, step):
156156
attestationResponse = None
157157

158158
# Check if user have registered devices
159-
count = CdiUtil.bean(UserService).countFido2RegisteredDevices(userName, self.fido2_domain)
159+
count = CdiUtil.bean(UserService).countFido2RegisteredDevices(userName)
160+
160161
if count > 0:
161162
print "Fido2. Prepare for step 2. Call Fido2 endpoint in order to start assertion flow"
162163

jans-auth-server/common/src/main/java/io/jans/as/common/service/common/fido2/RegistrationPersistenceService.java

+9-3
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,15 @@ public List<Fido2RegistrationEntry> findByRpRegisteredUserDevices(String userNam
121121

122122
Filter userInumFilter = Filter.createEqualityFilter("personInum", userInum);
123123
Filter registeredFilter = Filter.createEqualityFilter("jansStatus", Fido2RegistrationStatus.registered.getValue());
124-
Filter appIdFilter = Filter.createEqualityFilter("jansApp", rpId);
125-
Filter filter = Filter.createANDFilter(userInumFilter, registeredFilter, appIdFilter);
126-
124+
Filter filter = null;
125+
if (StringHelper.isNotEmpty(rpId)) {
126+
Filter appIdFilter = Filter.createEqualityFilter("jansApp", rpId);
127+
filter = Filter.createANDFilter(userInumFilter, registeredFilter, appIdFilter);
128+
}
129+
else
130+
{
131+
filter = Filter.createANDFilter(userInumFilter, registeredFilter);
132+
}
127133
List<Fido2RegistrationEntry> fido2RegistrationnEntries = persistenceEntryManager.findEntries(baseDn, Fido2RegistrationEntry.class, filter, returnAttributes);
128134

129135
return fido2RegistrationnEntries;

jans-auth-server/server/src/main/webapp/auth/fido2/platform.xhtml

+1-1
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ body {
158158
<h2>#{msgs['fido2.verification.stepverification']}</h2>
159159
<p>#{msgs['fido2.touch.verification.usedevice']}</p>
160160
<img
161-
src="#{oxAuthConfigurationService.getImgLocation()}/touchid.jpg"
161+
src="#{webConfigurationService.getImgLocation()}/touchid.jpg"
162162
alt="step_ver" />
163163
<h4>#{msgs['fido2.touch.verification.insertkey']}</h4>
164164
<p>#{msgs['fido2.touch.verification.useit']}</p>

jans-auth-server/server/src/main/webapp/auth/fido2/secKeys.xhtml

+1-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ body {
171171
<h2>#{msgs['fido2.verification.stepverification']}</h2>
172172
<p>#{msgs['fido2.verification.usedevice']}</p>
173173
<img
174-
src="#{oxAuthConfigurationService.getImgLocation()}/step_ver.png"
174+
src="#{webConfigurationService.getImgLocation()}/step_ver.png"
175175
alt="step_ver" />
176176
<h4>#{msgs['fido2.verification.insertkey']}</h4>
177177
<p>#{msgs['fido2.verification.useit']}</p>

jans-auth-server/server/src/main/webapp/stylesheet/style.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ login-panel {
207207

208208
.login-panel-header {
209209
background-color: #D4CFC7;
210-
background-image: url("#{oxAuthConfigurationService.getImgLocation()}/panel_header_bg.png");
210+
background-image: url("#{webConfigurationService.getImgLocation()}/panel_header_bg.png");
211211
background-position: left top;
212212
background-repeat: repeat-x;
213213
border-style: solid;

jans-fido2/server/src/main/java/io/jans/fido2/service/operation/AssertionService.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ private Pair<ArrayNode, String> prepareAllowedCredentials(String documentDomain,
325325
String.format("Can't find associated key '%s' for application '%s'", requestedKeyHandle, documentDomain)));
326326
existingFido2Registrations = Arrays.asList(fido2RegistrationEntry);
327327
} else {
328-
existingFido2Registrations = registrationPersistenceService.findByRpRegisteredUserDevices(username, documentDomain);
328+
existingFido2Registrations = registrationPersistenceService.findByRpRegisteredUserDevices(username, null);
329329
}
330330
// f.getRegistrationData().getAttenstationRequest() null check is added to maintain backward compatiblity with U2F devices when U2F devices are migrated to the FIDO2 server
331331
List<Fido2RegistrationEntry> allowedFido2Registrations = existingFido2Registrations.parallelStream()

0 commit comments

Comments
 (0)