Skip to content

fix(config-api): search filter logic for attribute resource #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Sep 6, 2022

Prepare


Description

The filter logic is wrongly combining two different data sets with OR filter

Target issue

closes #2309

Implementation Details

Rectified logic is use appropriate Filter.


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs pujavs requested a review from yuriyz as a code owner September 6, 2022 12:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yuriyz yuriyz merged commit c75ff1d into main Sep 6, 2022
@yuriyz yuriyz deleted the jans-config-api-fixes branch September 6, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(config-api): search filter needs to be fixed for Attribute resource
2 participants