Skip to content

🚀 Feature: Add suggestions to parameter-properties rule #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
JoshuaKGoldberg opened this issue Feb 15, 2025 · 0 comments · May be fixed by #14
Open
2 tasks done

🚀 Feature: Add suggestions to parameter-properties rule #11

JoshuaKGoldberg opened this issue Feb 15, 2025 · 0 comments · May be fixed by #14
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

Right now, the erasable-syntax-only/parameter-properties rule only reports a message on parameter properties. It doesn't provide any suggestions for how to fix them. Let's add one in to switch to traditional class properties.

Additional Info

As a part of this work, the docs/rules/parameter-properties.md docs file should be added to as well. Right now it just has a straightforward codeblock. A PR fixing this issue should:

  • Put a sub-heading on top of the existing example enum: ## Invalid Code
  • Add another code block under a ## Valid Code with what the rule would suggest
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀 labels Feb 15, 2025
@AlexMunoz AlexMunoz linked a pull request Feb 16, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant