Skip to content

Commit e7a6805

Browse files
authored
avoid excessive inlining of Ryu (#40593)
1 parent 1474566 commit e7a6805

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

base/ryu/exp.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@inline function writeexp(buf, pos, v::T,
1+
function writeexp(buf, pos, v::T,
22
precision=-1, plus=false, space=false, hash=false,
33
expchar=UInt8('e'), decchar=UInt8('.'), trimtrailingzeros=false) where {T <: Base.IEEEFloat}
44
@assert 0 < pos <= length(buf)

base/ryu/fixed.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@inline function writefixed(buf, pos, v::T,
1+
function writefixed(buf, pos, v::T,
22
precision=-1, plus=false, space=false, hash=false,
33
decchar=UInt8('.'), trimtrailingzeros=false) where {T <: Base.IEEEFloat}
44
@assert 0 < pos <= length(buf)

base/ryu/shortest.jl

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,10 @@ integer. If a `maxsignif` argument is provided, then `b < maxsignif`.
224224
return b, e10
225225
end
226226

227-
228-
@inline function writeshortest(buf::Vector{UInt8}, pos, x::T,
229-
plus=false, space=false, hash=true,
230-
precision=-1, expchar=UInt8('e'), padexp=false, decchar=UInt8('.'),
231-
typed=false, compact=false) where {T}
227+
function writeshortest(buf::Vector{UInt8}, pos, x::T,
228+
plus=false, space=false, hash=true,
229+
precision=-1, expchar=UInt8('e'), padexp=false, decchar=UInt8('.'),
230+
typed=false, compact=false) where {T}
232231
@assert 0 < pos <= length(buf)
233232
neg = signbit(x)
234233
# special cases

0 commit comments

Comments
 (0)