Skip to content

Commit f6804d6

Browse files
DilumAluthgeKristofferC
authored andcommitted
CI (Buildkite): move the sanitizers builders (e.g. asan) to the experimental pipeline (#41606)
(cherry picked from commit c95448f)
1 parent 22e7e24 commit f6804d6

File tree

4 files changed

+42
-6
lines changed

4 files changed

+42
-6
lines changed

.buildkite/experimental/0_webui.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# This file represents what is put into the webUI.
2+
# It is purely for keeping track of the changes we make to the webUI configuration; modifying this file has no effect.
3+
# We use the `cryptic` buildkite plugin to provide secrets management, which requires some integration into the WebUI's steps.
4+
agents:
5+
queue: "julia"
6+
sandbox.jl: "true"
7+
8+
steps:
9+
- label: ":unlock: Unlock secrets, launch pipelines"
10+
plugins:
11+
- staticfloat/cryptic:
12+
# Our list of pipelines that should be launched (but don't require a signature)
13+
# These pipelines can be modified by any contributor and CI will still run.
14+
# Build secrets will not be available in these pipelines (or their children)
15+
# but some of our signed pipelines can wait upon the completion of these unsigned
16+
# pipelines.
17+
unsigned_pipelines:
18+
- .buildkite/experimental/pipeline.yml

.buildkite/experimental/pipeline.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# This file launches all the build jobs that _don't_ require secrets access.
2+
# These jobs can pass their output off to jobs that do require secrets access,
3+
# but those privileged steps require signing before they can be run.
4+
#
5+
# Yes, this is creating another layer of indirection; the flow now looks like:
6+
#
7+
# [webui] -> pipeline.yml -> llvm_passes.yml
8+
#
9+
# when we could theoretically just have the `webui` launch `llvm_passes.yml`,
10+
# however this raises the bar for contributors to add new (unsigned) steps to
11+
# our CI configuration, so I'd rather live with an extra layer of indirection
12+
# and only need to touch the webui configuration when we need to alter
13+
# something about the privileged steps.
14+
steps:
15+
- label: ":buildkite: Launch unsigned pipelines"
16+
commands: |
17+
buildkite-agent pipeline upload .buildkite/experimental/sanitizers.yml
18+
agents:
19+
queue: julia

.buildkite/sanitizers.yml renamed to .buildkite/experimental/sanitizers.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ steps:
1414
- JuliaCI/julia#v1:
1515
version: 1.6
1616
- staticfloat/sandbox#v1:
17-
rootfs_url: https://github.com/JuliaCI/rootfs-images/releases/download/v1/llvm-passes.tar.gz
18-
rootfs_treehash: "f3ed53f159e8f13edfba8b20ebdb8ece73c1b8a8"
17+
rootfs_url: https://github.com/JuliaCI/rootfs-images/releases/download/v2.0/llvm_passes.tar.gz
18+
rootfs_treehash: "0b5a80c1d0ab110a57fbdb7f4bc042a5ede310f3"
1919
uid: 1000
2020
gid: 1000
2121
workspaces:
@@ -29,6 +29,6 @@ steps:
2929
echo "--- Test that ASAN is enabled"
3030
contrib/asan/check.jl ./tmp/test-asan/asan/usr/bin/julia-debug
3131
timeout_in_minutes: 120
32-
notify:
33-
- github_commit_status:
34-
context: "asan"
32+
# notify:
33+
# - github_commit_status:
34+
# context: "asan"

.buildkite/pipeline.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,5 @@ steps:
1919
buildkite-agent pipeline upload .buildkite/whitespace.yml
2020
buildkite-agent pipeline upload .buildkite/embedding.yml
2121
buildkite-agent pipeline upload .buildkite/llvm_passes.yml
22-
buildkite-agent pipeline upload .buildkite/sanitizers.yml
2322
agents:
2423
queue: julia

0 commit comments

Comments
 (0)