Skip to content

Adaptive basis refinement #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gkemlin opened this issue Apr 29, 2025 · 2 comments
Open

Adaptive basis refinement #1087

gkemlin opened this issue Apr 29, 2025 · 2 comments
Labels
discussion Discussion thread of broader scope

Comments

@gkemlin
Copy link
Collaborator

gkemlin commented Apr 29, 2025

Hi,

we would like with @ra-lainezr to implement in DFTK the error bounds we developed in this paper , so this post is not really an issue but rather a way to start brainstorming on how to do it. We have two main questions :

  1. We are able to track (approximate) discretization and SCF errors along the SCF iterations. How would you like it to be implemented ? Should it be by computed by default or if a flag is activated ?

  2. We would like to use it for basis refinement in terms of Ecut. At the moment, we just rebuild new basis, but this is not the most efficient way to do it. Is there already a function to build a basis with Ecut_large from a basis with Ecut_small < Ecut_large ? I could not find one, so maybe we should implement one.

PS: That's not urgent, just to start thinking about it 😄

@antoine-levitt
Copy link
Member

1 Behind a flag sounds good (at least at the beginning: if it's cheap and reasonable we can turn it on by default later). 2 I don't think so, but the cost of basis creation is not that huge anyway

@mfherbst mfherbst added the discussion Discussion thread of broader scope label May 2, 2025
@mfherbst
Copy link
Member

mfherbst commented May 2, 2025

Behind a flag sounds good

To me this is something where a marker struct could make sense. But perhaps a good way to think about it is also as a "macro-iteration" around a standard SCF ? Just thinking this may make it easier to also employ such things in direct minimisation or related algorithm.

cost of basis creation is not that huge anyway

Well depends on your problem. One can feel it for larger-ish systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion thread of broader scope
Projects
None yet
Development

No branches or pull requests

3 participants