-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix(core/balancer): fix a bug that the host_header
not set correctly
#13135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzssangglass
reviewed
Jun 3, 2024
tzssangglass
approved these changes
Jun 3, 2024
oowl
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vm-001
suggested changes
Jun 3, 2024
vm-001
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny code style
upstream entity can not be set correctly in requests to upstream as Host header when retries to upstream happen. FTI-5987
Co-authored-by: Yusheng Li <[email protected]>
Co-authored-by: Yusheng Li <[email protected]>
a2f828f
to
70bbcf8
Compare
vm-001
approved these changes
Jun 3, 2024
Successfully created cherry-pick PR for |
3 tasks
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
#13135) * fix(core/balancer): fix a bug that the `host_header` configured for upstream entity can not be set correctly in requests to upstream as Host header when retries to upstream happen. FTI-5987 --------- Co-authored-by: Yusheng Li <[email protected]> (cherry picked from commit e90cafc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix a bug that the
host_header
can not be set correctly as Host header in requests to upstream when retries happenChecklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
FTI-5987