Skip to content

feat(entities-vaults): add approle method support #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat(entities-vaults): add approle method support #1131

merged 1 commit into from
Jan 31, 2024

Conversation

Leopoldthecoder
Copy link
Member

Summary

For the HCV provider:

  • Adding support for approle auth method
  • Adding the missing kube_auth_path field which should have been added for Kong Gateway 3.5

Resources

@Leopoldthecoder Leopoldthecoder requested review from a team as code owners January 31, 2024 06:03
sumimakito
sumimakito approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and LGTM

@Leopoldthecoder Leopoldthecoder merged commit 11ea9ac into main Jan 31, 2024
@Leopoldthecoder Leopoldthecoder deleted the feat/hcv-approle-method branch January 31, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito sumimakito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @sumimakito