Skip to content

feat(entities-vaults): add aws vault fields #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented May 6, 2024

Summary

Adding missing AWS Vault fields: endpoint_url, assume_role_arn, and role_session_name.

KM-132

Resources

@Leopoldthecoder Leopoldthecoder requested review from a team as code owners May 6, 2024 03:30
@Leopoldthecoder Leopoldthecoder marked this pull request as draft May 6, 2024 03:42
@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review May 7, 2024 02:33
@Leopoldthecoder Leopoldthecoder enabled auto-merge (squash) May 7, 2024 02:57
Copy link
Contributor

@nekolab nekolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 8317de6 into main May 7, 2024
7 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/aws-fields branch May 7, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants