Skip to content

feat(entities-vaults): vault provider select #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Jul 10, 2024

Summary

Changing the vault provider cards into a select dropdown in VaultForm.

KM-311

Resources

@Leopoldthecoder Leopoldthecoder force-pushed the feat/vault-provider-select branch from 7735d93 to 6761107 Compare July 15, 2024 08:00
@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review July 15, 2024 08:31
@Leopoldthecoder Leopoldthecoder requested review from a team as code owners July 15, 2024 08:31
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested in host apps and LGTM

@Leopoldthecoder Leopoldthecoder merged commit 88c47ed into main Jul 15, 2024
7 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/vault-provider-select branch July 15, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants